travis/CI

.travis.yml

@@ -0,0 +1,61 @@
+sudo: true
+language: php
+addons:
+    mariadb: '10.2'
+services:
+    - mysql
+env:
+    global:
+        - PIMCORE_ENVIRONMENT=test
+        - DACHCOM_BUNDLE_TEST=1
+        - PIMCORE_TEST_URL=http://localhost
+        - PIMCORE_TEST_DB_DSN="mysql://root@localhost/dachcom_bundle_test"
+        - SYMFONY_DEPRECATIONS_HELPER=weak
+        - DACHCOM_TEST_SECTION=codeception
+matrix:
+    include:
+        -   name: "PHPStan Static Analysis (Pimcore 5.8.x, PHP 7.3)"
+            sudo: required
+            php: 7.3
+            env:
+                - PIMCORE_SKELETON_BRANCH="tags/v1.3.0"
+                - DACHCOM_TEST_SECTION=phpstan
+        -   name: "PHP ECS (Pimcore 5.8.x, PHP 7.3)"
+            sudo: required
+            php: 7.3
+            env:
+                - PIMCORE_SKELETON_BRANCH="tags/v1.3.0"
+                - DACHCOM_TEST_SECTION=ecs
+        -   name: "Codeception Tests ( Pimcore 5.8.x, PHP 7.2)"
+            sudo: required
+            php: 7.2
+            env:
+                - PIMCORE_SKELETON_BRANCH="tags/v1.3.0"
+        -   name: "Codeception Tests ( Pimcore 5.8.x, PHP 7.3)"
+            sudo: required
+            php: 7.3
+            env:
+                - PIMCORE_SKELETON_BRANCH="tags/v1.3.0"
+    allow_failures:
+        -   env:
+                - PIMCORE_SKELETON_BRANCH="tags/v1.3.0"
+                - DACHCOM_TEST_SECTION=ecs
+    fast_finish: true
+
+cache:
+    directories:
+        - $HOME/.composer/cache
+
+install:
+    - tests/_etc/travis/install
+
+after_failure:
+    - cd $TRAVIS_BUILD_DIR
+    - cat ./lib/DynamicSearchBundle/tests/_output/*
+
+script:
+    - _etc/travis/script
+
+notifications:
+    email:
+        - [email protected]

composer.json

@@ -27,6 +27,7 @@
         }
     },
     "require": {
+        "pimcore/pimcore": "^5.8.0",
         "zf1/zend-search-lucene": "~1.12"
     }
 }

easy-coding-standard.yml

@@ -0,0 +1,108 @@
+imports:
+    - { resource: '%vendor_dir%/symplify/easy-coding-standard/config/psr2.yml' }
+
+services:
+    PhpCsFixer\Fixer\Basic\BracesFixer:
+        allow_single_line_closure: true
+    PhpCsFixer\Fixer\PhpTag\BlankLineAfterOpeningTagFixer: ~
+    PhpCsFixer\Fixer\Operator\ConcatSpaceFixer:
+        spacing: one
+    PhpCsFixer\Fixer\Operator\NewWithBracesFixer: ~
+    PhpCsFixer\Fixer\Phpdoc\PhpdocAlignFixer:
+        tags:
+            - method
+            - param
+            - property
+            - return
+            - throws
+            - type
+            - var
+    PhpCsFixer\Fixer\Operator\BinaryOperatorSpacesFixer:
+        align_double_arrow: true
+    PhpCsFixer\Fixer\Operator\IncrementStyleFixer:
+        style: post
+    PhpCsFixer\Fixer\Operator\UnaryOperatorSpacesFixer: ~
+    PhpCsFixer\Fixer\Whitespace\BlankLineBeforeStatementFixer: ~
+    PhpCsFixer\Fixer\CastNotation\CastSpacesFixer: ~
+    PhpCsFixer\Fixer\LanguageConstruct\DeclareEqualNormalizeFixer: ~
+    PhpCsFixer\Fixer\FunctionNotation\FunctionTypehintSpaceFixer: ~
+    PhpCsFixer\Fixer\Comment\SingleLineCommentStyleFixer:
+        comment_types:
+            - hash
+    PhpCsFixer\Fixer\ControlStructure\IncludeFixer: ~
+    PhpCsFixer\Fixer\CastNotation\LowercaseCastFixer: ~
+    PhpCsFixer\Fixer\ClassNotation\ClassAttributesSeparationFixer:
+        elements:
+            - method
+    PhpCsFixer\Fixer\Casing\NativeFunctionCasingFixer: ~
+    PhpCsFixer\Fixer\ClassNotation\NoBlankLinesAfterClassOpeningFixer: ~
+    PhpCsFixer\Fixer\Phpdoc\NoBlankLinesAfterPhpdocFixer: ~
+    PhpCsFixer\Fixer\Comment\NoEmptyCommentFixer: ~
+    PhpCsFixer\Fixer\Phpdoc\NoEmptyPhpdocFixer: ~
+    PhpCsFixer\Fixer\Phpdoc\PhpdocSeparationFixer: ~
+    PhpCsFixer\Fixer\Semicolon\NoEmptyStatementFixer: ~
+    PhpCsFixer\Fixer\Whitespace\ArrayIndentationFixer: ~
+    PhpCsFixer\Fixer\Whitespace\NoExtraBlankLinesFixer:
+        tokens:
+            - curly_brace_block
+            - extra
+            - parenthesis_brace_block
+            - square_brace_block
+            - throw
+            - use
+    PhpCsFixer\Fixer\NamespaceNotation\NoLeadingNamespaceWhitespaceFixer: ~
+    PhpCsFixer\Fixer\ArrayNotation\NoMultilineWhitespaceAroundDoubleArrowFixer: ~
+    PhpCsFixer\Fixer\CastNotation\NoShortBoolCastFixer: ~
+    PhpCsFixer\Fixer\Semicolon\NoSinglelineWhitespaceBeforeSemicolonsFixer: ~
+    PhpCsFixer\Fixer\Whitespace\NoSpacesAroundOffsetFixer: ~
+    PhpCsFixer\Fixer\ControlStructure\NoTrailingCommaInListCallFixer: ~
+    PhpCsFixer\Fixer\ControlStructure\NoUnneededControlParenthesesFixer: ~
+    PhpCsFixer\Fixer\ArrayNotation\NoWhitespaceBeforeCommaInArrayFixer: ~
+    PhpCsFixer\Fixer\Whitespace\NoWhitespaceInBlankLineFixer: ~
+    PhpCsFixer\Fixer\ArrayNotation\NormalizeIndexBraceFixer: ~
+    PhpCsFixer\Fixer\Operator\ObjectOperatorWithoutWhitespaceFixer: ~
+    PhpCsFixer\Fixer\Phpdoc\PhpdocAnnotationWithoutDotFixer: ~
+    PhpCsFixer\Fixer\Phpdoc\PhpdocIndentFixer: ~
+    PhpCsFixer\Fixer\Phpdoc\PhpdocInlineTagFixer: ~
+    PhpCsFixer\Fixer\Phpdoc\PhpdocNoAccessFixer: ~
+    PhpCsFixer\Fixer\Phpdoc\PhpdocNoEmptyReturnFixer: ~
+    PhpCsFixer\Fixer\Phpdoc\PhpdocNoPackageFixer: ~
+    PhpCsFixer\Fixer\Phpdoc\PhpdocNoUselessInheritdocFixer: ~
+    PhpCsFixer\Fixer\Phpdoc\PhpdocReturnSelfReferenceFixer: ~
+    PhpCsFixer\Fixer\Phpdoc\PhpdocScalarFixer: ~
+    PhpCsFixer\Fixer\Phpdoc\PhpdocSingleLineVarSpacingFixer: ~
+    PhpCsFixer\Fixer\Phpdoc\PhpdocSummaryFixer: ~
+    PhpCsFixer\Fixer\Phpdoc\PhpdocToCommentFixer: ~
+    PhpCsFixer\Fixer\Phpdoc\PhpdocTrimFixer: ~
+    PhpCsFixer\Fixer\Phpdoc\PhpdocTypesFixer: ~
+    PhpCsFixer\Fixer\Phpdoc\PhpdocVarWithoutNameFixer: ~
+    PhpCsFixer\Fixer\FunctionNotation\ReturnTypeDeclarationFixer: ~
+    PhpCsFixer\Fixer\ClassNotation\SelfAccessorFixer: ~
+    PhpCsFixer\Fixer\CastNotation\ShortScalarCastFixer: ~
+    PhpCsFixer\Fixer\StringNotation\SingleQuoteFixer: ~
+    PhpCsFixer\Fixer\Semicolon\SpaceAfterSemicolonFixer: ~
+    PhpCsFixer\Fixer\Operator\StandardizeNotEqualsFixer: ~
+    PhpCsFixer\Fixer\Operator\TernaryOperatorSpacesFixer: ~
+    PhpCsFixer\Fixer\ArrayNotation\TrimArraySpacesFixer: ~
+    PhpCsFixer\Fixer\ArrayNotation\WhitespaceAfterCommaInArrayFixer: ~
+    PhpCsFixer\Fixer\ClassNotation\ClassDefinitionFixer:
+        singleLine: true
+    PhpCsFixer\Fixer\Casing\MagicConstantCasingFixer: ~
+    PhpCsFixer\Fixer\FunctionNotation\MethodArgumentSpaceFixer: ~
+    PhpCsFixer\Fixer\Alias\NoMixedEchoPrintFixer:
+        use: echo
+    PhpCsFixer\Fixer\Import\NoLeadingImportSlashFixer: ~
+    PhpCsFixer\Fixer\Import\NoUnusedImportsFixer: ~
+    PhpCsFixer\Fixer\PhpUnit\PhpUnitFqcnAnnotationFixer: ~
+    PhpCsFixer\Fixer\Phpdoc\PhpdocNoAliasTagFixer: ~
+    PhpCsFixer\Fixer\ClassNotation\ProtectedToPrivateFixer: ~
+    PhpCsFixer\Fixer\NamespaceNotation\SingleBlankLineBeforeNamespaceFixer: ~
+    PhpCsFixer\Fixer\ClassNotation\SingleClassElementPerStatementFixer: ~
+
+    # new since PHP-CS-Fixer 2.6
+    PhpCsFixer\Fixer\ControlStructure\NoUnneededCurlyBracesFixer: ~
+    PhpCsFixer\Fixer\ClassNotation\NoUnneededFinalMethodFixer: ~
+    PhpCsFixer\Fixer\Semicolon\SemicolonAfterInstructionFixer: ~
+
+    # new since 2.11
+    PhpCsFixer\Fixer\Operator\StandardizeIncrementFixer: ~

phpstan.neon

@@ -0,0 +1,13 @@
+includes:
+	- ../../vendor/phpstan/phpstan-symfony/extension.neon
+parameters:
+    reportUnmatchedIgnoredErrors: false
+    autoload_files:
+        - %currentWorkingDirectory%/vendor/pimcore/pimcore/stubs/compatibility-v4.php
+    symfony:
+        container_xml_path: var/cache/dev/appDevDebugProjectContainer.xml
+    ignoreErrors:
+        # There is no global constants definition file we could include, ignore it:
+        - '#Constant PIMCORE_[A-Z\\_]+ not found\.#'
+        # Symfony DI (remove this line with symfony 4.2):
+        - '#Call to an undefined method Symfony\\Component\\Config\\Definition\\Builder\\NodeDefinition::children\(\)\.#'

src/DsLuceneBundle/Configuration/Configuration.php

@@ -18,12 +18,12 @@ public function setConfig($config = [])
     }
 
     /**
-     * @param $slot
+     * @param string $slot
      *
      * @return mixed
      */
     public function get($slot)
     {
         return $this->config[$slot];
     }
-}
+}

src/DsLuceneBundle/Configuration/ConfigurationInterface.php

@@ -11,5 +11,4 @@ interface ConfigurationInterface
     const INDEX_BASE_GENESIS = self::INDEX_BASE . '/genesis';
 
     const INDEX_BASE_STABLE = self::INDEX_BASE . '/stable';
-
-}
+}

src/DsLuceneBundle/DependencyInjection/Configuration.php

@@ -14,4 +14,4 @@ public function getConfigTreeBuilder()
 
         return $treeBuilder;
     }
-}
+}

src/DsLuceneBundle/DependencyInjection/DsLuceneExtension.php

@@ -26,4 +26,4 @@ public function load(array $configs, ContainerBuilder $container)
         //$configManagerDefinition = $container->getDefinition(BundleConfiguration::class);
         //$configManagerDefinition->addMethodCall('setConfig', [$config]);
     }
-}
+}

src/DsLuceneBundle/DsLuceneBundle.php

@@ -30,4 +30,3 @@ protected function getComposerPackageName(): string
         return self::PACKAGE_NAME;
     }
 }
-

src/DsLuceneBundle/Index/Field/AbstractType.php

@@ -7,4 +7,4 @@
 abstract class AbstractType implements IndexFieldInterface
 {
     const UTF8 = 'UTF-8';
-}
+}

src/DsLuceneBundle/Index/Field/BinaryField.php

@@ -5,12 +5,12 @@
 final class BinaryField extends AbstractType
 {
     /**
-     * {@inheritDoc}
+     * {@inheritdoc}
      */
     public function build(string $name, $data, array $configuration = [])
     {
         $field = \Zend_Search_Lucene_Field::binary($name, $data);
-       // $field->boost = $type->getBoost() > 1 ? $type->getBoost() : 1.0;
+        // $field->boost = $type->getBoost() > 1 ? $type->getBoost() : 1.0;
 
         return $field;
     }

src/DsLuceneBundle/Index/Field/KeywordField.php

@@ -5,12 +5,12 @@
 final class KeywordField extends AbstractType
 {
     /**
-     * {@inheritDoc}
+     * {@inheritdoc}
      */
     public function build(string $name, $data, array $configuration = [])
     {
         $field = \Zend_Search_Lucene_Field::keyword($name, $data, self::UTF8);
-       // $field->boost = $type->getBoost() > 1 ? $type->getBoost() : 1.0;
+        // $field->boost = $type->getBoost() > 1 ? $type->getBoost() : 1.0;
 
         return $field;
     }

src/DsLuceneBundle/Index/Field/TextField.php

@@ -5,12 +5,12 @@
 final class TextField extends AbstractType
 {
     /**
-     * {@inheritDoc}
+     * {@inheritdoc}
      */
     public function build(string $name, $data, array $configuration = [])
     {
         $field = \Zend_Search_Lucene_Field::text($name, $data, self::UTF8);
-       // $field->boost = $type->getBoost() > 1 ? $type->getBoost() : 1.0;
+        // $field->boost = $type->getBoost() > 1 ? $type->getBoost() : 1.0;
 
         return $field;
     }

src/DsLuceneBundle/Index/Field/UnIndexedField.php

@@ -5,7 +5,7 @@
 final class UnIndexedField extends AbstractType
 {
     /**
-     * {@inheritDoc}
+     * {@inheritdoc}
      */
     public function build(string $name, $data, array $configuration = [])
     {

src/DsLuceneBundle/Index/Field/UnStoredField.php

@@ -2,12 +2,10 @@
 
 namespace DsLuceneBundle\Index\Field;
 
-use DynamicSearchBundle\Transformer\Container\FieldContainerInterface;
-
 final class UnStoredField extends AbstractType
 {
     /**
-     * {@inheritDoc}
+     * {@inheritdoc}
      */
     public function build(string $name, $data, array $configuration = [])
     {

src/DsLuceneBundle/Normalizer/DocumentKeyValueNormalizer.php

@@ -15,7 +15,7 @@ class DocumentKeyValueNormalizer implements DocumentNormalizerInterface
     protected $options;
 
     /**
-     * {@inheritDoc}
+     * {@inheritdoc}
      */
     public function configureOptions(OptionsResolver $resolver)
     {
@@ -27,15 +27,15 @@ public function configureOptions(OptionsResolver $resolver)
     }
 
     /**
-     * {@inheritDoc}
+     * {@inheritdoc}
      */
     public function setOptions(array $options)
     {
         $this->options = $options;
     }
 
     /**
-     * {@inheritDoc}
+     * {@inheritdoc}
      */
     public function normalize(ContextDataInterface $contextData, string $outputChannelName, $data)
     {
@@ -53,4 +53,4 @@ public function normalize(ContextDataInterface $contextData, string $outputChann
 
         return $normalizedDocuments;
     }
-}
+}

src/DsLuceneBundle/Normalizer/Helper/LuceneDocumentDataExtractor.php

@@ -15,7 +15,6 @@ public function extract(\Zend_Search_Lucene_Search_QueryHit $hit)
 
         $data = [];
         foreach ($document->getFieldNames() as $fieldName) {
-
             $field = null;
             $fieldDefinition = null;
 
@@ -33,7 +32,5 @@ public function extract(\Zend_Search_Lucene_Search_QueryHit $hit)
         }
 
         return $data;
-
     }
-
-}
+}