Fix when extraflags for thanos components were overridden #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes the scenario when settings for thanos components set via extra flags in values.yaml was overridden by values in a multicluster-config folder. Signed-off-by: michal.gubricky <[email protected]>
matofeder
reviewed
Feb 23, 2024
| "max_size": "500MB" | ||
| "max_size_items": 0 | ||
| "validity": 0s | ||
| "type": "in-memory" |
There was a problem hiding this comment.
IMO we should keep these extraFlags here.
IMO we should support the scenario when the end-user uses the base values and overrides some parameters like queryFrontend.enabled=True, then the end user should end with extraFlags we set for queryFrontend
matofeder
reviewed
Feb 23, 2024
| retentionResolution1h: 15d | ||
| extraFlags: | ||
| - --compact.concurrency=3 | ||
| - --downsample.concurrency=3 |
There was a problem hiding this comment.
matofeder
reviewed
Feb 23, 2024
| @@ -52,7 +52,19 @@ thanos: | |||
| existingObjstoreSecret: thanos-objstore-config | |||
| queryFrontend: | |||
| enabled: true | |||
| extraFlags: | |||
There was a problem hiding this comment.
IMO this file should be used as a values file which should override the default values file:
helm install .... -f multicluster-config/observer-values.yaml
then I do not think that these changes are necessary
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes the scenario when settings for thanos components, which are set via extra flags in
values.yamlwas overridden by values in a multicluster-config folder.