test(Metadata): add test to verify behavior of interceptors with context attached initial and trailing metadata #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ext attached initial and trailing metadata
| @@ -162,6 +168,16 @@ def test_modifying_interceptor(aio): | |||
| ) as client: | |||
| assert client.Execute(DummyRequest(input="test")).output == "TEST" | |||
|
|
|||
| def test_modifying_interceptor(): | |||
There was a problem hiding this comment.
It looks like you copied the test above without changing the name, so this ends up replacing the previous test. It'll need a unique name.
Could you also add an async version for consistency with other tests?
|
Hi @zakhenry I'm fine with adding this as a new test. Thanks! See comment for feedback. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure if this is useful to have in this repo, but I had a hard time working out how to get metadata working because the upstream docs in grpc are scant. This repo was a good place to test things out so thought I'd raise this PR in case it helps someone else out