Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set z-index for center dialog wrapper #984

Merged
merged 1 commit into from
Jul 27, 2023

Conversation

mstruebing
Copy link
Contributor

@mstruebing mstruebing commented Jul 27, 2023

Description

The change in #982 doesn't work as expected for the original issue.

Which issue(s) does this PR relate to?

Testing

  • Install the newest (15.0.0) ui-kit version
  • Go to the kommander-default-workspace
  • Disable cert-manager
  • Edit traefik (change configuration) and hit save to see the modal
  • see the editor still overalying the modal

Apply ui-kit changes from this PR like you usually do (npm link or copying files) and rerun the testing step, except the first one to install ui-kit. In the last step you should see the modal on top of the editor.

Trade-offs

Screenshots

before
Screenshot 2023-07-27 at 10 54 44

after

Screenshot 2023-07-27 at 10 56 49

Checklist

  • This PR is associated with a JIRA and it is mentioned in the commit message footer ("Closes …")
  • Significant changes have been tested downstream to avoid breaking changes
  • This PR contains breaking changes and states in the commit message body ("BREAKING CHANGE: …")
  • I have reviewed the changes and provided detail to the sections above

@mstruebing mstruebing self-assigned this Jul 27, 2023
@mstruebing mstruebing marked this pull request as ready for review July 27, 2023 09:00
@mstruebing mstruebing requested a review from a team as a code owner July 27, 2023 09:00
@github-actions
Copy link

github-actions bot commented Jul 27, 2023

Uffizzi Preview deployment-31918 was deleted.

@mstruebing mstruebing force-pushed the mstruebing/fix/z-index-for-center-dialog-wrapper branch from 547c4d9 to 29a2b02 Compare July 27, 2023 10:15
Copy link
Contributor

@seialkali seialkali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this and it's working 🎉

@mstruebing mstruebing merged commit 81cb820 into main Jul 27, 2023
5 checks passed
@mstruebing mstruebing deleted the mstruebing/fix/z-index-for-center-dialog-wrapper branch July 27, 2023 11:23
@github-actions
Copy link

🎉 This PR is included in version 15.0.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants