fix: recalibrate getTextColor function #983
Merged
+35
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Uffizzi Ephemeral Environment
|
mstruebing
approved these changes
Jul 27, 2023
Ensure that getTextColor is choosing colors with better contrast.
mstruebing
force-pushed
the
npina/fix/get-text-color-stronger-contrast
branch
from
7d31e4b
to
c3b0ee6
Compare
|
🎉 This PR is included in version 15.0.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure that getTextColor is choosing colors with better contrast.
Description
QA noticed that using this color #005E70 for a background color opted for a dark text color. This does not pass WCAG 2.0 AA compliance of a 4.5:1 contrast ratio for normal text. Therefore the text was hard to read on the background color.
I've adjusted and tested this function so that it will perform better and choose the text color with a higher color contrast.
Which issue(s) does this PR relate to?
Testing
The best way to test this would be to bring it in downstream. So either copy/paste the function over in the code or try to use npm link.
Trade-offs
This function is pretty complex 😅
Screenshots
Checklist