Merge pull request #431 from dcos-labs/mp/fix/select-field-hint-text

fix: show hint content under the select input
d2iq · Nov 7, 2019 · f9aebc3 · f9aebc3
2 parents b507e4d + 812f0f7
commit f9aebc3
Showing 1 changed file with 6 additions and 7 deletions.
diff --git a/packages/selectInput/components/SelectInput.tsx b/packages/selectInput/components/SelectInput.tsx
@@ -173,13 +173,12 @@ class SelectInput extends React.PureComponent<
                 />
               </span>
             </span>
-            {hasError &&
-              getValidationErrors && (
-                <div data-cy="selectInput-hintContent">
-                  {getHintContent}
-                  {hasError && getValidationErrors}
-                </div>
-              )}
+            {Boolean(getHintContent) || hasError ? (
+              <div data-cy="selectInput-hintContent">
+                {getHintContent}
+                {hasError && getValidationErrors}
+              </div>
+            ) : null}
           </div>
         )}
       </FormFieldWrapper>