Skip to content

Commit

Permalink
feat: node 18 support (#953)
Browse files Browse the repository at this point in the history
Closes D2IQ-96159
  • Loading branch information
nataliepina authored Jun 14, 2023
1 parent 6cd6143 commit f6a5fca
Show file tree
Hide file tree
Showing 6 changed files with 7 additions and 8 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ jobs:
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
with:
node-version: "16"
node-version-file: ".node-version"
- name: Install Dependencies 🔧
run: npm install
- name: Lint 🧹
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ jobs:
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
with:
node-version: "16"
node-version-file: ".node-version"
- name: Install Dependencies 🔧
run: npm install
- name: Semantic Release ⬆️
Expand Down
6 changes: 2 additions & 4 deletions .github/workflows/storybook-tests.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,4 @@
name: Storybook Tests
env:
NODE_VERSION: "16.16.0"
on: push
jobs:
test:
Expand All @@ -10,7 +8,7 @@ jobs:
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
with:
node-version: ${{ env.NODE_VERSION }}
node-version-file: ".node-version"
cache: "npm"
- name: Install Dependencies 🔧
run: npm ci
Expand All @@ -22,4 +20,4 @@ jobs:
run: |
npx concurrently -k -s first -n "SB,TEST" -c "magenta,blue" \
"npx http-server storybook_static --port 6006 --silent" \
"npx wait-on tcp:6006 && npm run test-storybook"
"npx wait-on http://127.0.0.1:6006 && npm run test-storybook"
1 change: 1 addition & 0 deletions .node-version
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
18.16.0
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@

## Prerequisites

Git, Node (version ^16.0.0), and NPM(version >=7.0.0) should be setup.
Git, Node (version ^18.0.0), and NPM(version >=9.0.0) should be setup.

UI Kit uses [React](https://reactjs.org/tutorial/tutorial.html) and [TypeScript](https://www.typescriptlang.org/docs/handbook/typescript-in-5-minutes.html).

Expand Down
2 changes: 1 addition & 1 deletion Dockerfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM node:16.13.0-slim
FROM node:18.16.0-slim

# Update apt-dependencies
RUN apt-get update -y
Expand Down

0 comments on commit f6a5fca

Please sign in to comment.