Skip to content

Commit

Permalink
feat: color prop for sectionloadingindicator (#727)
Browse files Browse the repository at this point in the history
Ability to set a custom color for the SectionLoadingIndicator.
Loading indicators story improvements included.
  • Loading branch information
nataliepina authored Jun 1, 2022
1 parent d5a2a15 commit 7d204d9
Show file tree
Hide file tree
Showing 6 changed files with 84 additions and 58 deletions.
27 changes: 19 additions & 8 deletions packages/loadingIndicator/components/SectionLoadingIndicator.tsx
Original file line number Diff line number Diff line change
@@ -1,13 +1,24 @@
import { css } from "@emotion/css";
import * as React from "react";
import { greyLight } from "../../design-tokens/build/js/designTokens";
import { sectionLoadingWrapper, sectionLoadingIndicator } from "../style";

const SectionLoadingIndicator = () => (
<div className={sectionLoadingWrapper}>
<div
className={sectionLoadingIndicator}
data-cy="sectionLoadingIndicator"
/>
</div>
);
export interface SectionLoadingIndicatorProps {
/** Custom color for the loading indicator */
color?: string;
}

const SectionLoadingIndicator = ({ color }: SectionLoadingIndicatorProps) => {
return (
<div className={sectionLoadingWrapper}>
<div
data-cy="sectionLoadingIndicator"
className={css(sectionLoadingIndicator, {
backgroundColor: color || greyLight
})}
/>
</div>
);
};

export default SectionLoadingIndicator;
Original file line number Diff line number Diff line change
@@ -0,0 +1,41 @@
import * as React from "react";
import { Story, Meta } from "@storybook/react";
import {
ConfigurationMap,
ConfigurationMapSection,
ConfigurationMapLabel,
ConfigurationMapRow,
ConfigurationMapValue
} from "../../configurationmap";

import { InlineLoadingIndicator } from "..";

export default {
title: "Feedback/Loading Indicators/Inline Loading Indicator",
component: InlineLoadingIndicator
} as Meta;

const Template: Story = args => (
<>
<ConfigurationMap>
<ConfigurationMapSection>
<ConfigurationMapRow>
<ConfigurationMapLabel>Name</ConfigurationMapLabel>
<ConfigurationMapValue>
<InlineLoadingIndicator {...args} />
</ConfigurationMapValue>
</ConfigurationMapRow>
<ConfigurationMapRow>
<ConfigurationMapLabel>Role</ConfigurationMapLabel>
<ConfigurationMapValue>UX Designer</ConfigurationMapValue>
</ConfigurationMapRow>
<ConfigurationMapRow>
<ConfigurationMapLabel>City</ConfigurationMapLabel>
<ConfigurationMapValue>San Francisco</ConfigurationMapValue>
</ConfigurationMapRow>
</ConfigurationMapSection>
</ConfigurationMap>
</>
);

export const Default = Template.bind({});
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
import * as React from "react";
import { Story, Meta } from "@storybook/react";

import { SectionLoadingIndicator } from "..";

export default {
title: "Feedback/Loading Indicators/Section Loading Indicator",
component: SectionLoadingIndicator,
argTypes: {
color: {
control: { type: "color" }
}
}
} as Meta;

const Template: Story = args => (
<>
<SectionLoadingIndicator {...args} />
</>
);

export const Default = Template.bind({});
47 changes: 0 additions & 47 deletions packages/loadingIndicator/stories/loadingIndicator.stories.tsx

This file was deleted.

3 changes: 1 addition & 2 deletions packages/loadingIndicator/style.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { css, keyframes } from "@emotion/css";
import { padding } from "../shared/styles/styleUtils";
import { iconSizeXl, greyLight } from "../design-tokens/build/js/designTokens";
import { iconSizeXl } from "../design-tokens/build/js/designTokens";

export const sectionLoadingWrapper = css`
${padding("all", "l")};
Expand Down Expand Up @@ -36,7 +36,6 @@ export const sectionLoadingIndicator = css`
animation-iteration-count: infinite;
animation-name: ${sectionLoadingKeyframes};
animation-timing-function: ease-in-out;
background-color: ${greyLight};
border-radius: 100%;
display: inline-block;
height: ${iconSizeXl};
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ exports[`Loading indicators renders InlineLoadingIndicator 1`] = `
class="css-1v9zxv1"
>
<div
class="css-15gzp3f"
class="css-1u93coa"
data-cy="sectionLoadingIndicator"
/>
</div>
Expand Down

0 comments on commit 7d204d9

Please sign in to comment.