Skip to content

Commit

Permalink
fix: tabindex values with updated versioning (#708)
Browse files Browse the repository at this point in the history
  • Loading branch information
@nataliepina
nataliepina authored Apr 28, 2022
1 parent 59e7796 commit 2c93780
Show file tree
Hide file tree
Showing 4 changed files with 22 additions and 166 deletions.
42 changes: 21 additions & 21 deletions package-lock.json
View file

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@
"react-chartist": "0.14.4",
"react-click-outside": "3.0.1",
"react-delegate-component": "1.0.0",
"react-focus-lock": "2.6.0",
"react-focus-lock": "2.8.1",
"react-id-generator": "3.0.2",
"react-popper": "2.2.5",
"react-tabs": "3.2.3",
Expand Down
118 changes: 0 additions & 118 deletions packages/modal/tests/__snapshots__/Modal.test.tsx.snap
View file
Original file line number Diff line number Diff line change
Expand Up @@ -827,11 +827,6 @@ exports[`Modal DialogModal renders DialogModal 1`] = `
style="width: 1px; height: 0px; padding: 0px; overflow: hidden; position: fixed; top: 1px; left: 1px;"
tabindex="0"
/>
<div
data-focus-guard="true"
style="width: 1px; height: 0px; padding: 0px; overflow: hidden; position: fixed; top: 1px; left: 1px;"
tabindex="1"
/>
<div
data-focus-lock-disabled="false"
>
Expand Down Expand Up @@ -874,11 +869,6 @@ exports[`Modal DialogModal renders DialogModal 1`] = `
style="width: 1px; height: 0px; padding: 0px; overflow: hidden; position: fixed; top: 1px; left: 1px;"
tabindex="0"
/>
<div
data-focus-guard="true"
style="width: 1px; height: 0px; padding: 0px; overflow: hidden; position: fixed; top: 1px; left: 1px;"
tabindex="1"
/>
<div
data-focus-lock-disabled="false"
>
Expand Down Expand Up @@ -921,11 +911,6 @@ exports[`Modal DialogModal renders DialogModal 1`] = `
style="width: 1px; height: 0px; padding: 0px; overflow: hidden; position: fixed; top: 1px; left: 1px;"
tabindex="0"
/>
<div
data-focus-guard="true"
style="width: 1px; height: 0px; padding: 0px; overflow: hidden; position: fixed; top: 1px; left: 1px;"
tabindex="1"
/>
<div
data-focus-lock-disabled="false"
>
Expand Down Expand Up @@ -968,11 +953,6 @@ exports[`Modal DialogModal renders DialogModal 1`] = `
style="width: 1px; height: 0px; padding: 0px; overflow: hidden; position: fixed; top: 1px; left: 1px;"
tabindex="0"
/>
<div
data-focus-guard="true"
style="width: 1px; height: 0px; padding: 0px; overflow: hidden; position: fixed; top: 1px; left: 1px;"
tabindex="1"
/>
<div
data-focus-lock-disabled="false"
>
Expand Down Expand Up @@ -1478,11 +1458,6 @@ exports[`Modal DialogModal renders DialogModal 1`] = `
style="width: 1px; height: 0px; padding: 0px; overflow: hidden; position: fixed; top: 1px; left: 1px;"
tabindex="0"
/>
<div
data-focus-guard="true"
style="width: 1px; height: 0px; padding: 0px; overflow: hidden; position: fixed; top: 1px; left: 1px;"
tabindex="1"
/>
<div
data-focus-lock-disabled="false"
>
Expand Down Expand Up @@ -1634,22 +1609,6 @@ exports[`Modal DialogModal renders DialogModal 1`] = `
}
tabIndex={0}
/>
<div
data-focus-guard={true}
key="guard-nearest"
style={
Object {
"height": "0px",
"left": "1px",
"overflow": "hidden",
"padding": 0,
"position": "fixed",
"top": "1px",
"width": "1px",
}
}
tabIndex={1}
/>
<SideEffect(FocusWatcher)
autoFocus={true}
crossFrame={true}
Expand Down Expand Up @@ -3734,11 +3693,6 @@ exports[`Modal FullscreenModal renders FullscreenModal 1`] = `
style="width: 1px; height: 0px; padding: 0px; overflow: hidden; position: fixed; top: 1px; left: 1px;"
tabindex="0"
/>
<div
data-focus-guard="true"
style="width: 1px; height: 0px; padding: 0px; overflow: hidden; position: fixed; top: 1px; left: 1px;"
tabindex="1"
/>
<div
data-focus-lock-disabled="false"
>
Expand Down Expand Up @@ -3781,11 +3735,6 @@ exports[`Modal FullscreenModal renders FullscreenModal 1`] = `
style="width: 1px; height: 0px; padding: 0px; overflow: hidden; position: fixed; top: 1px; left: 1px;"
tabindex="0"
/>
<div
data-focus-guard="true"
style="width: 1px; height: 0px; padding: 0px; overflow: hidden; position: fixed; top: 1px; left: 1px;"
tabindex="1"
/>
<div
data-focus-lock-disabled="false"
>
Expand Down Expand Up @@ -3828,11 +3777,6 @@ exports[`Modal FullscreenModal renders FullscreenModal 1`] = `
style="width: 1px; height: 0px; padding: 0px; overflow: hidden; position: fixed; top: 1px; left: 1px;"
tabindex="0"
/>
<div
data-focus-guard="true"
style="width: 1px; height: 0px; padding: 0px; overflow: hidden; position: fixed; top: 1px; left: 1px;"
tabindex="1"
/>
<div
data-focus-lock-disabled="false"
>
Expand Down Expand Up @@ -3875,11 +3819,6 @@ exports[`Modal FullscreenModal renders FullscreenModal 1`] = `
style="width: 1px; height: 0px; padding: 0px; overflow: hidden; position: fixed; top: 1px; left: 1px;"
tabindex="0"
/>
<div
data-focus-guard="true"
style="width: 1px; height: 0px; padding: 0px; overflow: hidden; position: fixed; top: 1px; left: 1px;"
tabindex="1"
/>
<div
data-focus-lock-disabled="false"
>
Expand Down Expand Up @@ -4007,11 +3946,6 @@ exports[`Modal FullscreenModal renders FullscreenModal 1`] = `
style="width: 1px; height: 0px; padding: 0px; overflow: hidden; position: fixed; top: 1px; left: 1px;"
tabindex="0"
/>
<div
data-focus-guard="true"
style="width: 1px; height: 0px; padding: 0px; overflow: hidden; position: fixed; top: 1px; left: 1px;"
tabindex="1"
/>
<div
data-focus-lock-disabled="false"
>
Expand Down Expand Up @@ -4139,11 +4073,6 @@ exports[`Modal FullscreenModal renders FullscreenModal 1`] = `
style="width: 1px; height: 0px; padding: 0px; overflow: hidden; position: fixed; top: 1px; left: 1px;"
tabindex="0"
/>
<div
data-focus-guard="true"
style="width: 1px; height: 0px; padding: 0px; overflow: hidden; position: fixed; top: 1px; left: 1px;"
tabindex="1"
/>
<div
data-focus-lock-disabled="false"
>
Expand Down Expand Up @@ -4591,11 +4520,6 @@ exports[`Modal FullscreenModal renders FullscreenModal 1`] = `
style="width: 1px; height: 0px; padding: 0px; overflow: hidden; position: fixed; top: 1px; left: 1px;"
tabindex="0"
/>
<div
data-focus-guard="true"
style="width: 1px; height: 0px; padding: 0px; overflow: hidden; position: fixed; top: 1px; left: 1px;"
tabindex="1"
/>
<div
data-focus-lock-disabled="false"
>
Expand Down Expand Up @@ -4729,22 +4653,6 @@ exports[`Modal FullscreenModal renders FullscreenModal 1`] = `
}
tabIndex={0}
/>
<div
data-focus-guard={true}
key="guard-nearest"
style={
Object {
"height": "0px",
"left": "1px",
"overflow": "hidden",
"padding": 0,
"position": "fixed",
"top": "1px",
"width": "1px",
}
}
tabIndex={1}
/>
<SideEffect(FocusWatcher)
autoFocus={true}
crossFrame={true}
Expand Down Expand Up @@ -6087,11 +5995,6 @@ exports[`Modal ModalBase renders ModalBase 1`] = `
style="width: 1px; height: 0px; padding: 0px; overflow: hidden; position: fixed; top: 1px; left: 1px;"
tabindex="0"
/>
<div
data-focus-guard="true"
style="width: 1px; height: 0px; padding: 0px; overflow: hidden; position: fixed; top: 1px; left: 1px;"
tabindex="1"
/>
<div
data-focus-lock-disabled="false"
>
Expand Down Expand Up @@ -6241,11 +6144,6 @@ exports[`Modal ModalBase renders ModalBase 1`] = `
style="width: 1px; height: 0px; padding: 0px; overflow: hidden; position: fixed; top: 1px; left: 1px;"
tabindex="0"
/>
<div
data-focus-guard="true"
style="width: 1px; height: 0px; padding: 0px; overflow: hidden; position: fixed; top: 1px; left: 1px;"
tabindex="1"
/>
<div
data-focus-lock-disabled="false"
>
Expand Down Expand Up @@ -6312,22 +6210,6 @@ exports[`Modal ModalBase renders ModalBase 1`] = `
}
tabIndex={0}
/>
<div
data-focus-guard={true}
key="guard-nearest"
style={
Object {
"height": "0px",
"left": "1px",
"overflow": "hidden",
"padding": 0,
"position": "fixed",
"top": "1px",
"width": "1px",
}
}
tabIndex={1}
/>
<SideEffect(FocusWatcher)
autoFocus={true}
crossFrame={true}
Expand Down
26 changes: 0 additions & 26 deletions packages/popover/tests/__snapshots__/Popover.test.tsx.snap
View file
Original file line number Diff line number Diff line change
Expand Up @@ -497,11 +497,6 @@ exports[`Popover renders an open dropdown 1`] = `
style="width: 1px; height: 0px; padding: 0px; overflow: hidden; position: fixed; top: 1px; left: 1px;"
tabindex="0"
/>
<div
data-focus-guard="true"
style="width: 1px; height: 0px; padding: 0px; overflow: hidden; position: fixed; top: 1px; left: 1px;"
tabindex="1"
/>
<div
data-focus-lock-disabled="false"
>
Expand Down Expand Up @@ -607,11 +602,6 @@ exports[`Popover renders an open dropdown 1`] = `
style="width: 1px; height: 0px; padding: 0px; overflow: hidden; position: fixed; top: 1px; left: 1px;"
tabindex="0"
/>
<div
data-focus-guard="true"
style="width: 1px; height: 0px; padding: 0px; overflow: hidden; position: fixed; top: 1px; left: 1px;"
tabindex="1"
/>
<div
data-focus-lock-disabled="false"
>
Expand Down Expand Up @@ -701,22 +691,6 @@ exports[`Popover renders an open dropdown 1`] = `
}
tabIndex={0}
/>
<div
data-focus-guard={true}
key="guard-nearest"
style={
Object {
"height": "0px",
"left": "1px",
"overflow": "hidden",
"padding": 0,
"position": "fixed",
"top": "1px",
"width": "1px",
}
}
tabIndex={1}
/>
<SideEffect(FocusWatcher)
autoFocus={true}
crossFrame={true}
Expand Down

0 comments on commit 2c93780

Please sign in to comment.