Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First of all thank you for this package and the work you've put into it.
I have implemented OffsetCommit Request (Version 5) and OffsetFetch Request (Version 6). This is tested against Kafka 2.2.2.
This enables the tracking of:
I did not implement
CollectClientMetrics
for these requests since we're not using metrics at the moment.Hope this is useful!
PS: Happy to modify this further if you think it's necessary 👍