Skip to content

Commit

Permalink
Use PodName as input
Browse files Browse the repository at this point in the history
The TrialName can be parse from the pod name.

This seems currently a good way to get the trial name. For
more discussion see: kubeflow#2109
  • Loading branch information
votti committed Feb 10, 2023
1 parent 0d25cbf commit 03b8795
Showing 1 changed file with 4 additions and 3 deletions.
7 changes: 4 additions & 3 deletions cmd/metricscollector/v1beta1/kfpv1-metricscollector/main.py
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ def parse_options():

# TODO (andreyvelich): Add early stopping flags.
parser.add_argument("-s-db", "--db_manager_server_addr", type=str, default="")
parser.add_argument("-t", "--trial_name", type=str, default="")
parser.add_argument("-t", "--pod_name", type=str, default="")
parser.add_argument(
"-path",
"--metrics_file_dir",
Expand Down Expand Up @@ -76,6 +76,7 @@ def parse_options():
opt = parse_options()
wait_all_processes = opt.wait_all_processes.lower() == "true"
db_manager_server = opt.db_manager_server_addr.split(":")
trial_name = '-'.join(opt.pod_name.split('-')[:-1])
if len(db_manager_server) != 2:
raise Exception(
"Invalid Katib DB manager service address: %s" % opt.db_manager_server_addr
Expand All @@ -99,14 +100,14 @@ def parse_options():
with api_pb2.beta_create_DBManager_stub(channel) as client:
logger.info(
"In "
+ opt.trial_name
+ trial_name
+ " "
+ str(len(observation_log.metric_logs))
+ " metrics will be reported."
)
client.ReportObservationLog(
api_pb2.ReportObservationLogRequest(
trial_name=opt.trial_name, observation_log=observation_log
trial_name=trial_name, observation_log=observation_log
),
timeout=timeout_in_seconds,
)

0 comments on commit 03b8795

Please sign in to comment.