Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2024.6 release #88

Merged
merged 19 commits into from
Jun 5, 2024
Merged

2024.6 release #88

merged 19 commits into from
Jun 5, 2024

Conversation

czue
Copy link
Owner

@czue czue commented Jun 4, 2024

(not ready for merge)


**isort**
The configuration for the tools can be found in the [`pyproject.toml`][toml] file, using the same syntax as `black`.
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@snopoke was there a reason you didn't switch to ruff.toml? just curious.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to avoid an extra config file

3. Run isort: `isort -l 120 --profile black .`
1. Install ruff: `pip install ruff`
2. Run ruff linting `ruff check --extend-exclude migrations --line-length 120 . --fix`
3. Run ruff formatting: `ruff format --line-length 120 .`
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@snopoke does this look right?

@czue czue merged commit 97b6525 into main Jun 5, 2024
6 checks passed
@czue czue deleted the develop branch June 5, 2024 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants