CORE-2016: added request body validation to the `POST /v1/plans/:plan…

…-id/rates` endpoint
cyverse · Oct 30, 2024 · 99476db · 99476db
1 parent 5d84e2c
commit 99476db
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 0 deletions.
diff --git a/internal/controllers/plans.go b/internal/controllers/plans.go
@@ -431,6 +431,9 @@ func (s Server) AddPlanRates(ctx echo.Context) error {
 	if err = ctx.Bind(&planRateList); err != nil {
 		return model.Error(ctx, err.Error(), http.StatusBadRequest)
 	}
+	if err = planRateList.Validate(); err != nil {
+		return model.Error(ctx, err.Error(), http.StatusBadRequest)
+	}
 
 	// Begin a transaction.
 	return s.GORMDB.Transaction(func(tx *gorm.DB) error {

diff --git a/internal/httpmodel/new_plan.go b/internal/httpmodel/new_plan.go
@@ -315,6 +315,15 @@ func (prl *NewPlanRateList) Validate() error {
 		}
 	}
 
+	// Check for multiple plan rates with the same effective date.
+	uniquePlanRates := make(map[int64]bool)
+	for _, pr := range prl.PlanRates {
+		if uniquePlanRates[pr.EffectiveDate.UnixMilli()] {
+			return fmt.Errorf("multiple plan rates found with the same effective date")
+		}
+		uniquePlanRates[pr.EffectiveDate.UnixMilli()] = true
+	}
+
 	return nil
 }