Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CORE-1955 App Version Ordering Form #605

Merged
merged 4 commits into from
Nov 21, 2024

Conversation

psarando
Copy link
Member

@psarando psarando commented Nov 2, 2024

This PR will add an App Version Ordering Form that uses the endpoint added by cyverse-de/terrain#290.

App Version Ordering Form


A new menu item will be added to the apps listing row dot-menu for apps the user can edit:
Apps Listing Row Dot-Menu

Also initial VersionsOrdering story.
Updated VersionsOrderingForm with API calls to the
`PUT /apps/:system/:id/versions` endpoint.
@psarando psarando added the enhancement New feature or request label Nov 2, 2024
@psarando
Copy link
Member Author

psarando commented Nov 5, 2024

I think this should be ready for review now, although I might hold off on merging it until the QA db is back up, so I can test it against some local services and the QA db.

@psarando psarando marked this pull request as ready for review November 5, 2024 22:40
Copy link
Member

@slr71 slr71 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't catch any issues. 👍

@psarando
Copy link
Member Author

I'm going to go ahead and merge this now, thanks for the review 👍

@psarando psarando merged commit 51b2bb4 into cyverse-de:main Nov 21, 2024
6 checks passed
@psarando psarando deleted the CORE-1955-app-ver-reorder branch November 21, 2024 02:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants