CORE-2002 VICE Countdown Timers #584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds countdown timers for running VICE analyses in the listing, submission landing, and dashboard. Also refactors fetching the time limit and enabling the extend action, hopefully simplifying some of the logic.
Adding another CardHeader for the countdown timer can hide the actions at the bottom of the card, so replace the "Running" subheader with the countdown timer instead.
Updated the analyses listing, submission landing, and dashboard stories to display the running VICE countdown timer, but only when a time limit is selected in the story controls. Updated the start and end dates in the `info` analysis mock to help the "Running for" duration labels to make more sense.
This will also fix the duration display for analyses stories, since they all share a job history mock, with a Tapis job in the first step.
|
I would prefer time to be hours:min no need for seconds. If we can say Time Remaining: HH:MM that would be better |
slr71
approved these changes
Aug 12, 2024
| </DERow> | ||
| ); | ||
| })} | ||
| analyses.map((analysis, index) => ( |
There was a problem hiding this comment.
I like the idea of reducing the nesting depth here. 👍
Display countdown timer as "Time Remaining: HHh:MMm", and only update every minute. Since this is a shorter string, it can now fit in the AnalysisSubheader in place of the running duration and date string in the dashboard.
Display countdown timer as "Time Remaining: HH:MM", without units.
|
Here are the screenshots for the original countdown format for comparison: Analysis Listing: Analysis Landing page: Dashboard Item: Here are the screenshots for the previous countdown format for comparison: Analysis Listing: Analysis Landing page: Dashboard Item: |
|
Thanks for the reviews! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will add countdown timers for running VICE analyses in the listing, submission landing, and the dashboard.
Analysis Listing:
Analysis Landing page:
Dashboard Item:
