Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small update to use the _first_ @ rather than the last for username truncation #583

Merged
merged 1 commit into from
Jul 31, 2024

Conversation

ianmcorvidae
Copy link
Member

There's one other spot we're using the suffix, but it already removes all @ signs (it splits on @ and then takes the first returned component). I guess it won't do exactly what it should if for some reason the username suffix differs from the configured value, but I'm just not that worried about that. This change is (I think) only relevant to display, but still seemed better to be consistent.

Copy link
Member

@slr71 slr71 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ianmcorvidae ianmcorvidae merged commit 356a087 into cyverse-de:main Jul 31, 2024
6 checks passed
@ianmcorvidae ianmcorvidae deleted the username-suffix branch July 31, 2024 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants