Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CORE-1966 Initial Local Contexts support in Metadata Templates #560

Merged

Conversation

psarando
Copy link
Member

@psarando psarando commented Dec 8, 2023

This PR will add initial Local Contexts support in Metadata Templates.

  • Updated the mock DataciteMetadataTemplate with DataCite 4.2 and Local Contexts changes in QA.
  • Added markdown support for Metadata Template attribute descriptions.
  • Allow multi-line input for String attributes.
  • Converted Enum attribute fields to select FormTextFields for consistency in other forms.

image

@psarando psarando added the enhancement New feature or request label Dec 8, 2023
@psarando psarando force-pushed the CORE-1966-local-contexts-template branch from da3c02f to ac5a6f4 Compare December 11, 2023 16:45
* Updated the mock DataciteMetadataTemplate with DataCite 4.2 and
Local Contexts changes in QA.

* Added markdown support for Metadata Template attribute descriptions.

* Updated Markdown converter to always open links in a new window.

* Allow multiline input for template String attributes and AVU values.

* Converted Enum attribute fields to `select` FormTextFields
for consistency in other forms.
@psarando psarando force-pushed the CORE-1966-local-contexts-template branch from ac5a6f4 to 96cece8 Compare December 11, 2023 18:16
Copy link
Member

@slr71 slr71 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! :shipit:

@psarando
Copy link
Member Author

Thanks for the review! 👍

@psarando psarando merged commit 442f18e into cyverse-de:master Dec 13, 2023
6 checks passed
@psarando psarando deleted the CORE-1966-local-contexts-template branch December 13, 2023 02:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants