CORE-1952 Display limit check errors from instant launch actions #549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Updated the `InstantLaunchButtonWrapper` to check for error codes
related to VICE permission or limit errors, and to display the same
related dialog as displayed from the `AppName` in the apps listing.
* Since `POST /analyses` does not return `limitChecks` info in errors,
refactored the `instantlyLaunch` service facade to parse `limitChecks`
info from the `/quicklaunches/{id}/app-info` call it already makes,
and to reject the call if the `canRun` flag is set to `false`.
* Removed `catch` from `instantlyLaunch` promises so that errors from
those endpoints can be properly displayed in the UI
(rather than causing undefined `ql` or `app` exceptions).
* Refactored `RunErrorDialog` from `AppName` into its own component.
* Removed duplicate `usageSummary*Response` mocks from data stories.
* Removed duplicate template args from data listing stories.
* Fixed a deprecated `rows` warning in `FormMultilineTextField`.
* Added missing and updated vice i18n namespaces to pages.
psarando
commented
Oct 14, 2023
| @@ -358,14 +356,29 @@ export const instantlyLaunch = ({ instantLaunch, resource, output_dir }) => { | |||
| // Contains the Promises that resolve to the data needed to perform a job submission. | |||
| const promiseList = [ | |||
| savedLaunchPromise, | |||
| getAppInfo({ launchId: savedLaunchId }).catch((e) => console.log(e)), | |||
| getAppInfo({ launchId: savedLaunchId }), | |||
There was a problem hiding this comment.
Not sure why the errors from these promises were getting caught and ignored, but I removed those catches so that errors from those endpoints can be properly displayed in the UI (rather than causing undefined ql or app exceptions below).
slr71
approved these changes
Oct 14, 2023
Comment on lines
+12
to
+20
| const SupportLink = (props) => ( | ||
| <Link | ||
| variant="body1" | ||
| component="button" | ||
| onClick={intercomShow} | ||
| {...props} | ||
| /> | ||
| ); | ||
|
|
|
Thanks for the review! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will update the
InstantLaunchButtonWrapperto check for error codes related to VICE permission or limit errors, and to display the same related dialog as displayed from theAppNamein the apps listing.Since
POST /analysesdoes not returnlimitChecksinfo in errors, I had to refactor theinstantlyLaunchservice facade to parselimitChecksinfo from the/quicklaunches/{id}/app-infocall it already makes, and to reject the analysis submission if thecanRunflag is set tofalse.