Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CORE 1961 #547

Merged
merged 12 commits into from
Oct 10, 2023
Merged

CORE 1961 #547

merged 12 commits into from
Oct 10, 2023

Conversation

sboleyn
Copy link
Contributor

@sboleyn sboleyn commented Oct 2, 2023

Add configuration setting that can be used to disable data search in the DE
Remove data search features from the DE when data search is disabled
-Remove data filter
-Remove data tab and data tab panel
-Disable data search queries
-Set default tab to 'apps' when clicking enter to search on globalsearchfield

@sboleyn
Copy link
Contributor Author

sboleyn commented Oct 3, 2023

Screen Shot 2023-10-03 at 2 10 15 PM Screen Shot 2023-10-03 at 2 10 44 PM Screen Shot 2023-10-03 at 2 11 04 PM

Copy link
Member

@psarando psarando left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this LGTM, but we should see if this will still work by using defaultTab consts rather than state and useEffects.

src/components/search/GlobalSearchField.js Outdated Show resolved Hide resolved
src/pages/search.js Outdated Show resolved Hide resolved
Copy link
Member

@psarando psarando left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@sboleyn sboleyn merged commit ce9d266 into cyverse-de:master Oct 10, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants