Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some handling to create an analysis details link in emails #16

Merged
merged 2 commits into from
Oct 2, 2024

Conversation

ianmcorvidae
Copy link
Member

No description provided.

Copy link
Member

@psarando psarando left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@@ -83,6 +83,7 @@ func FormatMessage(ctx context.Context, emailReq EmailRequest, payload map[strin
payload["DEToolsLink"] = deSettings.base + deSettings.tools
payload["DECollectionsLink"] = deSettings.base + deSettings.collections
payload["DEAppsLink"] = deSettings.base + deSettings.apps
payload["DEAnalysesLink"] = deSettings.base + deSettings.analyses
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this isn't being used anywhere?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, right. I was going to add this as a fallback in case we don't have an analysis ID. I'll add that to the template now.

@ianmcorvidae ianmcorvidae merged commit 90138b6 into cyverse-de:main Oct 2, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants