Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add /apps/communities/{community-id}/apps endpoints. #126

Merged
merged 1 commit into from
Oct 18, 2018

Conversation

psarando
Copy link
Member

This PR will add (/admin)/apps/communities/{community-id}/apps endpoints for listing apps tagged with a community AVU for #125.

Currently checks an Agave app's ontology list for the community group's name, though this may not be appropriate for this kind of tag.

Copy link
Member

@slr71 slr71 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! I had one minor suggestion for a docstring update, but that was it. :shipit: whenever you're ready.

src/apps/service/apps/de/listings.clj Outdated Show resolved Hide resolved
Adds (/admin)/apps/communities/{community-id}/apps endpoints for listing
apps tagged with a community AVU.

Currently checks an Agave app's ontology list for the community group's
name, though this may not be appropriate for this kind of tag.
@psarando
Copy link
Member Author

Thanks for the review!

@psarando psarando merged commit 2cb2510 into cyverse-de:master Oct 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants