Mark the planned end date read from the database as a local timestamp #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ianmcorvidae
force-pushed
the
update-time-limit-endpoint
branch
from
0b3ff2a to
522710a
Compare
ianmcorvidae
force-pushed
the
update-time-limit-endpoint
branch
from
522710a to
91c5cf5
Compare
|
Looks like I had misunderstood |
|
After the updates, I'm going to go ahead and merge this to test with in QA. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this is the fix for the time-limit endpoint issue. The timestamps in the DB were set correctly, but the way we were reading them in assumed UTC, where they are actually local timestamps. Calling
.Local()doesn't change timestamps in go, merely marks them as belonging to the local timezone, so this should cause them to start being returned correctly after being converted to unix epoch values.