Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix breadthfirst layout to center all rows vertically and each row horizontally; and to respect a given bounding box #3292

Conversation

soetji
Copy link
Contributor

@soetji soetji commented Nov 8, 2024

Associated issues:

**Notes

  • This PR fixes all the issues above from:
Screenshot 2024-11-06 at 10 06 56 PM Screenshot 2024-11-06 at 10 06 56 PM copy 2
Screen.Recording.2024-11-06.at.10.06.17.PM.mov
  • This PR fixes all the issues above to:
Screen.Recording.2024-11-06.at.10.07.49.PM.mov
  • This PR updates let variable declarations to const, when appropriate, in src/extensions/layout/breadthfirst.js

Checklist

Author:

  • The proper base branch has been selected. New features go on unstable. Bug-fix patches can go on either unstable or master.
  • Automated tests have been included in this pull request, if possible, for the new feature(s) or bug fix. Check this box if tests are not pragmatically possible (e.g. rendering features could include screenshots or videos instead of automated tests).
  • The associated GitHub issues are included (above).
  • Notes have been included (above).

Reviewers:

  • All automated checks are passing (green check next to latest commit).
  • At least one reviewer has signed off on the pull request.
  • For bug fixes: Just after this pull request is merged, it should be applied to both the master branch and the unstable branch. Normally, this just requires cherry-picking the corresponding merge commit from master to unstable -- or vice versa.

@mikekucera mikekucera merged commit 14b3730 into cytoscape:unstable Nov 8, 2024
1 check passed
@mikekucera
Copy link
Contributor

This will get released in 3.31.0
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants