-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Module 2.md #3
Open
Yahnoosh
wants to merge
1
commit into
cynotebo:master
Choose a base branch
from
Yahnoosh:patch-1
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@liamca, @LuisCabrer could you give me write access to this repo? |
Ok, let's do the move today/tomorrow... It's ok if folks in Vancouver still use your copy.
We can track their changes if they make any and integrate them into the main repository.
Thanks!
-Luis.
From: Cindy Noteboom <[email protected]>
Sent: Monday, September 23, 2019 1:33 PM
To: Luis Cabrera-Cordon <[email protected]>; cynotebo/KM-Workshop <[email protected]>; cynotebo/KM-Workshop <[email protected]>
Cc: Mention <[email protected]>
Subject: RE: [cynotebo/KM-Workshop] Update Module 2.md (#3)
I already took care of Janusz (he told me I was too late anyway so I agree, this core issue is now resolved).
We can move the code whenever you say so. I agree it should go under the main solution accelerator and would be happy for it to go live there forever after. I believe all the changes agreed upon Friday are in, so if we move today/tomorrow it will be in place for the Vancouver workshop.
From: Luis Cabrera-Cordon <[email protected]<mailto:[email protected]>>
Sent: Monday, September 23, 2019 1:30 PM
To: cynotebo/KM-Workshop <[email protected]<mailto:[email protected]>>; cynotebo/KM-Workshop <[email protected]<mailto:[email protected]>>; Cindy Noteboom <[email protected]<mailto:[email protected]>>
Cc: Mention <[email protected]<mailto:[email protected]>>
Subject: RE: [cynotebo/KM-Workshop] Update Module 2.md (#3)
@cindy Noteboom<mailto:[email protected]>, can you grant Jansuz access as a contributor? His github alias is Yahnoosh.
Also, can you grant Liam and I admin rights so we can add other contributors?
That said, I am not going to approve this change simply because we made changes to this section since this was submitted, so I think the core issue is now resolved.
We should move this code to the solution accelerator so that we don't have to depend on a github owned by one of us. When?
Thanks!
-Luis
From: Janusz Lembicz <[email protected]<mailto:[email protected]>>
Sent: Wednesday, September 18, 2019 2:22 AM
To: cynotebo/KM-Workshop <[email protected]<mailto:[email protected]>>
Cc: Luis Cabrera-Cordon <[email protected]<mailto:[email protected]>>; Mention <[email protected]<mailto:[email protected]>>
Subject: Re: [cynotebo/KM-Workshop] Update Module 2.md (#3)
@liamca<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fliamca&data=02%7C01%7CLuis.Cabrera-Cordon%40microsoft.com%7C2929bfafed1e4f70aadd08d7406547b1%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637048676041115927&sdata=XW6BhoQPcfWh6SCi%2Bb7Vy%2F68pGfITfLf7flQJKS6mr0%3D&reserved=0>, @LuisCabrer<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FLuisCabrer&data=02%7C01%7CLuis.Cabrera-Cordon%40microsoft.com%7C2929bfafed1e4f70aadd08d7406547b1%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637048676041125931&sdata=%2FL%2FaNG8nFpUgi7u2B9hCruCzMn2CCUQHggRnneiOeN4%3D&reserved=0> could you give me write access to this repo?
-
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fcynotebo%2FKM-Workshop%2Fpull%2F3%3Femail_source%3Dnotifications%26email_token%3DACFUG3AYGM3YH2R5CPPNCZDQKHXKLA5CNFSM4IX4AOJKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD67NLFI%23issuecomment-532600213&data=02%7C01%7CLuis.Cabrera-Cordon%40microsoft.com%7C2929bfafed1e4f70aadd08d7406547b1%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637048676041135940&sdata=Z4dh5j2pNzYJqMtjExpeuIUVNnGlQbCx4SgWT5U6Tks%3D&reserved=0>, or mute the thread<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FACFUG3F3RWIZXUFKW73DIM3QKHXKLANCNFSM4IX4AOJA&data=02%7C01%7CLuis.Cabrera-Cordon%40microsoft.com%7C2929bfafed1e4f70aadd08d7406547b1%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637048676041145952&sdata=ugea%2BfHidlzkaEUGiMJo%2B7eC7vX%2FdnOmRGHJna%2FUoLE%3D&reserved=0>.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating the notes for configuring CognitiveSearch.UI application to be more specific to this workshop.