Skip to content

Commit

Permalink
info: prevent info view being selected as the default view
Browse files Browse the repository at this point in the history
  • Loading branch information
oliver-sanders committed Dec 11, 2024
1 parent 18760a6 commit 9b33929
Showing 1 changed file with 11 additions and 1 deletion.
12 changes: 11 additions & 1 deletion src/views/UserProfile.vue
Original file line number Diff line number Diff line change
Expand Up @@ -195,7 +195,7 @@ along with this program. If not, see <http://www.gnu.org/licenses/>.
</v-col>
<v-select
v-model="defaultView"
:items="Array.from($options.allViews.keys())"
:items="defaultViews"
:prepend-inner-icon="$options.allViews.get(defaultView).icon"
data-cy="select-default-view"
:menu-props="{ 'data-cy': 'select-default-view-menu' }"
Expand Down Expand Up @@ -247,6 +247,16 @@ export default {

computed: {
...mapState('user', ['user']),

defaultViews () {
const views = Array.from(this.$options.allViews.keys())

// filter out the "Info" view as this cannot presently be opened on the
// workflow itself, only jobs inside of the workflow
// https://github.com/cylc/cylc-ui/issues/1898 will resolve this
views.pop('Info')
return views
}
},

methods: {
Expand Down

0 comments on commit 9b33929

Please sign in to comment.