-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lint S014: Only warn about -W
when used for LSF
#6551
Conversation
575053f
to
404adc1
Compare
a way which indicates use of LSF.
316ded6
to
fef13fb
Compare
I found some suggestion in the user guide that the time can take a longer format:
Maybe: Might be worth quickly running this rule over avaliable cylc-run dirs to make sure there aren't any false positives. |
This regex is only supposed to match LSF format wallclock strings, avoiding PBS The PBS check one will match any case where I've added an extra test to demonstrate my point. |
-W
when used for LSF-W
when used for LSF
Can't find any false positives in the first 2000 workflows scanned, 👍 |
Co-authored-by: Ronnie Dutta <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI: There's an (ironic?) lint error on this branch to resolve.
Closes #6550
-W
should only be highlighted by Cylc lint when being used in a way which indicates use of LSF.Check List
CONTRIBUTING.md
and added my name as a Code Contributor.setup.cfg
(andconda-environment.yml
if present).