Cleanup source code prior to release #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
muthenberg
force-pushed
the
task/STAD-565_clean-source
branch
from
3e8bc18 to
36a79a2
Compare
muthenberg
force-pushed
the
task/STAD-565_clean-source
branch
from
36a79a2 to
ea251c3
Compare
hb0
previously approved these changes
Apr 10, 2024
DataCapturing/README.md
Outdated
| You can implement your own data storage if you like by reacting to the messages sent from a running `Measurement` and storing the captured data however you like. | ||
|
|
||
| For convenience, the Cyface SDK provides its own data storage layer, which is designed to receive sensor data from a `Measurement` and store it to a permanent storage area. | ||
| The default implmentations provided with the SDK uses Apples *CoreData* framework. |
There was a problem hiding this comment.
just a type: implementations .... use(not uses)
There was a problem hiding this comment.
actually it is "implementation ... uses"
DataCapturing/README.md
Outdated
|
|
||
| * **Measurement:** Represent a single measurement in the database. It has two attributes `synchronizable` and `synchronized`, tracking if it is possible and necessary to synchronize this measurement with a storage server. Each measurement also gets a device wide unique `identifier`, which is implemented as a counter. | ||
| * **Track:** A measurement contains one or more tracks. A track is created when the measurement is resumed after a pause. | ||
| * **Event:** This tracks user interactions like putton presses to manipulate an active measurement. Start, stop, pause and resume events are recorded as this entity as well as modality changes. |
There was a problem hiding this comment.
typo: button.... events are recorded as this entity? (did you mean as "an" entity?)
There was a problem hiding this comment.
No. Since this is an Entity-Relationship-Diagram all the boxes are called "Entity" and thus "Event" is an "Entity" and the four events "Start", "Stop", "Pause" and "Resume" are recorded as an "Event-Entity", so they are recorded as this (the explained one) Entity.
hb0
approved these changes
Apr 11, 2024
hb0
approved these changes
Apr 11, 2024
muthenberg
added a commit
that referenced
this pull request
Apr 11, 2024
Cleanup source code prior to release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many of those over 1.000 changed files are just deleted old generated documentation files. Maybe concentrate on the *.swift files and maybe even more important the updated README.md.
... and just ignore the fact, that this does not build. I've created a new task for that issue and as I told you also created a StackOverflow-Question about this. It works with XCode, just not using terminal commands.