Task/leip 164 upload images #289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hb0
force-pushed
the
task/LEIP-164_upload-images
branch
2 times, most recently
from
9d7c5b5 to
74837a7
Compare
hb0
force-pushed
the
task/LEIP-164_upload-images
branch
from
223f2b2 to
827cd8b
Compare
hb0
force-pushed
the
task/LEIP-164_upload-images
branch
from
26ba803 to
11e08f2
Compare
hb0
force-pushed
the
task/LEIP-164_upload-images
branch
from
11e08f2 to
d6ee15d
Compare
hb0
force-pushed
the
task/LEIP-164_upload-images
branch
from
3467764 to
79a1f05
Compare
hb0
force-pushed
the
task/LEIP-164_upload-images
branch
from
e54d3d5 to
48c7123
Compare
hb0
force-pushed
the
task/LEIP-164_upload-images
branch
from
5604a32 to
2c120f8
Compare
hb0
commented
Oct 31, 2023
persistence/src/androidTest/kotlin/de/cyface/persistence/content/LocationSerializerTest.kt
Show resolved
Hide resolved
synchronization/src/main/kotlin/de/cyface/synchronization/DefaultUploadProgressListener.kt
Outdated
Show resolved
Hide resolved
hb0
force-pushed
the
task/LEIP-164_upload-images
branch
from
d107a0a to
241f558
Compare
muthenberg
requested changes
Nov 1, 2023
persistence/src/main/kotlin/de/cyface/persistence/model/ParcelableFile.kt
Outdated
Show resolved
Hide resolved
persistence/src/main/kotlin/de/cyface/persistence/serialization/FileSerializer.kt
Outdated
Show resolved
Hide resolved
persistence/src/main/kotlin/de/cyface/persistence/serialization/TransferFileSerializer.kt
Outdated
Show resolved
Hide resolved
synchronization/src/androidTest/kotlin/de/cyface/synchronization/SyncPerformerTest.kt
Show resolved
Hide resolved
hb0
force-pushed
the
task/LEIP-164_upload-images
branch
from
2d347bb to
c726a86
Compare
muthenberg
approved these changes
Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recommendation:
Use commit-wise reviewing or else you will be confused because Github's "Files changed" view will think I changed a previously named class "FileDao" but I've renamed the old class to a more correct name "FileIOHandler" and added a new FileDao class which follows the recommended Android architecture for Room and data access.