[WIP] DI containerの設定 #138
+135
−25
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| // | ||
| // CoordinatorAssembly.swift | ||
| // SyncPod | ||
| // | ||
| // Created by 森篤史 on 2018/05/20. | ||
| // Copyright © 2018年 Cyder. All rights reserved. | ||
| // | ||
|
|
||
| import UIKit | ||
| import Swinject | ||
|
|
||
| class CoordinatorAssembly: Assembly { | ||
| func assemble(container: Container) { | ||
| container.register(ApplicationCoordinator.self) { res in | ||
| ApplicationCoordinator( | ||
| welcomeCoordinator: res.resolve(WelcomeCoordinator.self)! | ||
| ) | ||
| }.inObjectScope(.container) | ||
|
|
||
| container.register(WelcomeCoordinator.self) { _ in | ||
| WelcomeCoordinator() | ||
| }.inObjectScope(.container) | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| // | ||
| // DependencyManager.swift | ||
| // SyncPod | ||
| // | ||
| // Created by 森篤史 on 2018/05/21. | ||
| // Copyright © 2018年 Cyder. All rights reserved. | ||
| // | ||
|
|
||
| import Swinject | ||
| import SwinjectStoryboard | ||
|
|
||
| class DependencyManager { | ||
| static let assembler = Assembler([ | ||
|
There was a problem hiding this comment. カプセル化を試みているなら，ここはprivateの方がいいかもしれないです． There was a problem hiding this comment. また，この実装だとどこからでもDI出来てしまうが，それが実装意図に沿っているかも併せて気になりました． |
||
| CoordinatorAssembly(), | ||
| ViewModelAssembly(), | ||
| ViewControllerAssembly() | ||
| ], container: SwinjectStoryboard.defaultContainer) | ||
|
|
||
| static func getResolver() -> Resolver { | ||
| return assembler.resolver | ||
| } | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| // | ||
| // ViewControllerAssembly.swift | ||
| // SyncPod | ||
| // | ||
| // Created by 森篤史 on 2018/05/20. | ||
| // Copyright © 2018年 Cyder. All rights reserved. | ||
| // | ||
|
|
||
| import Swinject | ||
| import SwinjectStoryboard | ||
|
|
||
| class ViewControllerAssembly: Assembly { | ||
| func assemble(container: Container) { | ||
| container.storyboardInitCompleted(WelcomeViewConstoller.self) { res, viewController in | ||
| viewController.viewModel = res.resolve(WelcomeViewModel.self)! | ||
|
There was a problem hiding this comment. 抽象に依存してないが，これは実装意図に沿っているだろうか． |
||
| } | ||
| } | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| // | ||
| // ViewModelAssembly.swift | ||
| // SyncPod | ||
| // | ||
| // Created by 森篤史 on 2018/05/20. | ||
| // Copyright © 2018年 Cyder. All rights reserved. | ||
| // | ||
|
|
||
| import Swinject | ||
|
|
||
| class ViewModelAssembly: Assembly { | ||
| func assemble(container: Container) { | ||
| container.register(WelcomeViewModel.self) { res in | ||
| WelcomeViewModel( | ||
| coordinator: res.resolve(WelcomeCoordinator.self)! | ||
| ) | ||
| }.inObjectScope(.container) | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CoordinatorをDIするメリットがあまり思いつかなかったんだが，どういったメリットが有るんだろうか．