New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

リファクタ：ViewModel等で共通化できるものを共通化する #238

Closed

mori-atsushi wants to merge 2 commits into new-architecture from 237-refactor

Collaborator

mori-atsushi commented Apr 29, 2018

close #237

Mori Atsushi added 2 commits

April 29, 2018 22:10


          [clear] resourcesをBaseClassで渡すようにした

cc89d80


          [clear] onPauseSubjectをBaseClassに移動

e39faa3

mori-atsushi added WIP wait for review labels

mori-atsushi requested a review from chigichan24

April 29, 2018 13:30

Collaborator Author

mori-atsushi commented Apr 29, 2018

@chigichan24 resourceのところはいいにしても、onPauseSubjectのところはごちゃごちゃしすぎな気もするので、ご意見欲しいです。

mori-atsushi closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

wait for review WIP