Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polishing and methods renaming #26

Merged
merged 18 commits into from
Jun 11, 2024
Merged

Polishing and methods renaming #26

merged 18 commits into from
Jun 11, 2024

Conversation

roxblnfk
Copy link
Member

🔍 What was changed

Rename find() to findByPK()
Polish composer.json

🤔 Why?

I think findByPK is more clear name than find when findOne is near

📝 Checklist

  • Closes #
  • How was this tested:
    • Tested manually
    • Unit tests added

📃 Documentation

Copy link

codecov bot commented May 30, 2024

Codecov Report

Attention: Patch coverage is 40.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 69.41%. Comparing base (a30dc32) to head (cb25505).

Files Patch % Lines
src/Repository/ActiveRepository.php 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             master      #26   +/-   ##
=========================================
  Coverage     69.41%   69.41%           
  Complexity       32       32           
=========================================
  Files             7        7           
  Lines            85       85           
=========================================
  Hits             59       59           
  Misses           26       26           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@roxblnfk roxblnfk merged commit d8616f8 into master Jun 11, 2024
19 of 21 checks passed
@roxblnfk roxblnfk deleted the polishing branch June 11, 2024 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants