Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

api: remove v1beta1 #602

Merged
merged 3 commits into from
Nov 21, 2023
Merged

api: remove v1beta1 #602

merged 3 commits into from
Nov 21, 2023

Conversation

shunki-fujita
Copy link
Contributor

@shunki-fujita shunki-fujita commented Nov 6, 2023 •
edited
Loading

@shunki-fujita shunki-fujita force-pushed the remove_v1beta1 branch 4 times, most recently from 05910c7 to 7e2c5dd Compare November 6, 2023 09:50
@shunki-fujita shunki-fujita marked this pull request as ready for review November 7, 2023 04:33
@shunki-fujita shunki-fujita force-pushed the remove_v1beta1 branch 2 times, most recently from ce74436 to 0f367f4 Compare November 14, 2023 08:34
yamatcha
yamatcha reviewed Nov 20, 2023
View reviewed changes
Makefile Outdated
@@ -70,13 +70,10 @@ manifests: controller-gen kustomize yq ## Generate WebhookConfiguration, Cluster
.PHONY: generate
generate: controller-gen conversion-gen ## Generate code containing DeepCopy, DeepCopyInto, and DeepCopyObject method implementations.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove dependencies to conversion gen.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

19345ab

@yamatcha
Copy link
Contributor

yamatcha commented Nov 20, 2023 •
edited
Loading

@shunki-fujita
make manifests task build the crd manifest using in envtest, it's not only related conversion webhook.
Please replace this as Outputs static CRDs for use with Envtest.

moco/Makefile

Line 66 in 4320da9

$(KUSTOMIZE) build config/crd -o config/crd/tests # Outputs static CRDs with conversion webhook enabled for use with Envtest.

There are patch manifests for conversion webhook. These should also be removed.
https://github.com/cybozu-go/moco/blob/main/config/crd/patches/webhook_in_backuppolicies.yaml
https://github.com/cybozu-go/moco/blob/main/config/crd/patches/webhook_in_mysqlclusters.yaml
Please comment out this line to build manifests without conversion webhook.

moco/config/crd/kustomization.yaml

Line 14 in 4320da9

- patches/webhook_in_mysqlclusters.yaml

@yamatcha yamatcha merged commit 4b26fdb into main Nov 21, 2023
15 checks passed
@yamatcha yamatcha deleted the remove_v1beta1 branch November 21, 2023 05:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yamatcha yamatcha yamatcha approved these changes

@zoetrope zoetrope Awaiting requested review from zoetrope

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shunki-fujita @yamatcha