Add tls settings for BackupPolicy

[kmdkuk]

• Add ca-cert flag to moco-backup
• Add caCert field to BackupPolicy
• Enable minio tls used for testing
• Add test using minio with TLS
  • refactoring: Use Gomega matcher in Eventually on backup_test

Signed-off-by: kouki [email protected]

[ymmt2005]

Ideally, we should run 2 minio instances, one with TLS enabled and another with disabled.
And run the tests for both.

[kmdkuk]

@ymmt2005

Thank you for your comment.
I intentionally created only tests with TLS enabled, thinking that it would be enough to have tests with TLS enabled.
Why is it better to have both cases?
Is it a test coverage issue?

[ymmt2005]

I just thought it was not enough.

[kmdkuk]

I wanted to add test cases a little more intelligently, but I added tests using two minio.
137c8c0

[ymmt2005]

@kmdkuk thank you!

[kmdkuk]

There was conflict, so I resolve it.

[ymmt2005]

This looks like a fundamental error.

STEP: getting process list

• Failure [29.555 seconds]
kill
/home/runner/work/moco/moco/pkg/dbop/kill_test.go:20
  should kill non-system processes only [It]
  /home/runner/work/moco/moco/pkg/dbop/kill_test.go:21

  Unexpected error:
      <*fmt.wrapError | 0xc000[202](https://github.com/cybozu-go/moco/actions/runs/6647568774/job/18063192309?pr=580#step:6:203)4e0>: 
      sql: Scan error on column index 3, name "STATE": converting NULL to string is unsupported
      {
          msg: "sql: Scan error on column index 3, name \"STATE\": converting NULL to string is unsupported",
          err: <*errors.errorString | 0xc0000563c0>{
              s: "converting NULL to string is unsupported",
          },
      }
  occurred

  /home/runner/work/moco/moco/pkg/dbop/kill_test.go:46

Cc: @zoetrope

[ymmt2005]

No it's not. It's just due to a poor test code...

type process struct {
        ID    uint64 `db:"ID"`
        User  string `db:"USER"`
        Host  string `db:"HOST"`
        State string `db:"STATE"` // for debugging
}

var _ = Describe("kill", func() {
        It("should kill non-system processes only", func() {
                By("preparing a single node cluster")
                cluster := &mocov1beta2.MySQLCluster{}
                cluster.Namespace = "test"
                cluster.Name = "kill"
                cluster.Spec.Replicas = 1

                passwd, err := password.NewMySQLPassword()
                Expect(err).NotTo(HaveOccurred())

                op, err := factory.New(context.Background(), cluster, passwd, 0)
                Expect(err).NotTo(HaveOccurred())

                By("creating a user and making a connection with the user")
                _, err = op.(*operator).db.Exec("SET GLOBAL read_only=0")
                Expect(err).NotTo(HaveOccurred())
                _, err = op.(*operator).db.Exec("CREATE USER 'foo'@'%' IDENTIFIED BY 'bar'")
                Expect(err).NotTo(HaveOccurred())
                db, err := factory.(*testFactory).newConn(context.Background(), cluster, "foo", "bar", 0)
                Expect(err).NotTo(HaveOccurred())
                defer db.Close()

                By("getting process list")
                var procs []process
                err = op.(*operator).db.Select(&procs, `SELECT ID, USER, HOST, STATE FROM information_schema.PROCESSLIST`)
                Expect(err).NotTo(HaveOccurred())

[ymmt2005]

@kmdkuk @zoetrope
can you fix that bug in kill_test.go? I think we should use sql.NullString.
https://pkg.go.dev/database/sql#NullString

[ymmt2005]

@masa213f
That State field is added by you.
I have a question; why did you define a new type process instead of adding the State field to the existing type Process?

[morimoto-cybozu]

LGTM

[masa213f]

@ymmt2005

I have a question; why did you define a new type process instead of adding the State field to the existing type Process?

It is just for debugging. I meant to delete the type process when I finished the debug, but I forgot.
The kill_test.go has been flaky before #515. But I don't know the reason why kill connection failed. So I tried to get more information.

[ymmt2005]

@masa213f Thank you for answering. So, are you going to remove it?

[masa213f]

@ymmt2005
Yes. I'll revert the PR. I had not been sure that the flaky test was fixed by the Eventually.
#595