Stop reconciliation and clustering #578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d-kuro
force-pushed
the
d-kuro/stop
branch
3 times, most recently
from
2025656
to
22ca4f7
Compare
d-kuro
force-pushed
the
d-kuro/stop
branch
2 times, most recently
from
debb10e
to
69b7f78
Compare
d-kuro
changed the title
kmdkuk
reviewed
Nov 16, 2023
Signed-off-by: d-kuro <[email protected]>
Signed-off-by: d-kuro <[email protected]>
Signed-off-by: d-kuro <[email protected]>
Signed-off-by: d-kuro <[email protected]>
Signed-off-by: d-kuro <[email protected]>
Signed-off-by: d-kuro <[email protected]>
Signed-off-by: d-kuro <[email protected]>
Signed-off-by: d-kuro <[email protected]>
Signed-off-by: d-kuro <[email protected]>
Signed-off-by: d-kuro <[email protected]>
Signed-off-by: d-kuro <[email protected]>
Signed-off-by: d-kuro <[email protected]>
Signed-off-by: d-kuro <[email protected]>
Signed-off-by: d-kuro <[email protected]>
Signed-off-by: d-kuro <[email protected]>
|
I have added functionality to display messages when stopping or resuming clustering and reconciliation using the |
|
LGTM |
zoetrope
reviewed
Nov 29, 2023
| } | ||
|
|
||
| if equality.Semantic.DeepEqual(orig, cluster) { | ||
| return nil |
There was a problem hiding this comment.
I want a message like "The clustering is already running."
| } | ||
|
|
||
| if equality.Semantic.DeepEqual(orig, cluster) { | ||
| return nil |
There was a problem hiding this comment.
ditto.
I want a message like "The reconciliation is already running."
| cluster.Annotations[constants.AnnClusteringStopped] = "true" | ||
|
|
||
| if equality.Semantic.DeepEqual(orig, cluster) { | ||
| return nil |
| cluster.Annotations[constants.AnnReconciliationStopped] = "true" | ||
|
|
||
| if equality.Semantic.DeepEqual(orig, cluster) { | ||
| return nil |
Signed-off-by: d-kuro <[email protected]>
This was referenced Dec 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs:
#572
#564
Add the enhancement to stop clustering and reconciling MySQLCluster based on the following design document.
https://github.com/cybozu-go/moco/blob/main/docs/designdoc/clustering_stop.md