Skip to content

Commit

Permalink
Fix test due to k8s 1.20
Browse files Browse the repository at this point in the history
  • Loading branch information
masa213f authored and kfyharukz committed Jan 25, 2021
1 parent 8a1d212 commit 6315fce
Showing 1 changed file with 21 additions and 11 deletions.
32 changes: 21 additions & 11 deletions e2e/gc_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -20,18 +20,28 @@ func testGarbageCollector() {
stdout, stderr, err := kubectl("delete", "-n", "e2e-test", "-f", "manifests/mysql_cluster.yaml")
Expect(err).ShouldNot(HaveOccurred(), "stdout=%s, stderr=%s", stdout, stderr)

for _, kind := range []string{"configmaps", "service", "cronjobs", "jobs", "statefulsets", "pods"} {
Eventually(func() error {
stdout, stderr, err := kubectl("get", "-n", "e2e-test", kind)
if err != nil {
return fmt.Errorf("failed to get resource. stdout: %s, stderr: %s, err: %v", stdout, stderr, err)
}
if !strings.Contains(string(stderr), "No resources found in e2e-test namespace.") {
return fmt.Errorf("resources remain: %s, stdout: %s, stderr: %s", kind, stdout, stderr)
}
kinds := strings.Join([]string{"configmaps", "services", "cronjobs", "jobs", "statefulsets", "pods"}, ",")
Eventually(func() error {
stdout, stderr, err := kubectl("get", "-n", "e2e-test", kinds, "-o", "name")
if err != nil {
return fmt.Errorf("failed to get resource. stdout: %s, stderr: %s, err: %v", stdout, stderr, err)
}
resources := strings.Split(strings.TrimSuffix(string(stdout), "\n"), "\n")

// k8s >=v1.20 does not need this condition,
// because kube-root-ca.crt cm is created in every namespace.
// Please remove this line when the support for k8s <=v1.19 is dropped
if len(resources) == 1 && resources[0] == "" {
return nil
}, 2*time.Minute).Should(Succeed())
}
}
if len(resources) == 1 && resources[0] == "configmap/kube-root-ca.crt" {

fmt.Println("only remain configmap/kube-root-ca.crt")
return nil
}

return fmt.Errorf("resources remain: %s", resources)
}, 2*time.Minute).Should(Succeed())

for _, resource := range []string{
"serviceaccount/mysqld-sa-" + moco.UniqueName(cluster),
Expand Down

0 comments on commit 6315fce

Please sign in to comment.