use unix domain socket for all connections to MySQL #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moco-agent holds several MySQL connection pools. Most of these connections use unix domain sockets, but only one uses a TCP connection. This connection does not use TLS, so if MySQL is set to require_secure_transport=ON, moco-agent will not start. This patch changes moco-agent to use unix domain sockets for all connections to MySQL. This change allows moco-agent to run even if require_secure_transport=ON is set for MySQL. Signed-off-by: Daichi Mukai <[email protected]>
daichimukai
force-pushed
the
use-uds-for-all-connections-to-mysql
branch
from
4bf3ab7
to
68a0864
Compare
4 tasks
|
@daichimukai In my personal opinion, at least the health check should be checked over a TCP connection. And there are several problems besides this issue. (ref: cybozu-go/moco#544) |
|
@masa213f |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
moco-agent holds several MySQL connection pools. Most of these connections use unix domain sockets, but only one uses a TCP connection. This connection does not use TLS, so if MySQL is set to require_secure_transport=ON, moco-agent will not start.
This patch changes moco-agent to use unix domain sockets for all connections to MySQL. This change allows moco-agent to run even if require_secure_transport=ON is set for MySQL.