Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support extra parameters in the templates #52

Merged
merged 3 commits into from
May 23, 2024
Merged

Support extra parameters in the templates #52

merged 3 commits into from
May 23, 2024

Conversation

zoetrope
Copy link
Member

@zoetrope zoetrope commented May 17, 2024

This PR enables the use of extra parameters for each tenant within the AppProject and RoleBinding templates.
This feature will be useful when a tenant's name does not match GitHub team name.

The ExtraParams of a delegated tenant can be used within the templates.
However, this change introduces an error if the delegated tenant does not exist within the cluster.

@zoetrope zoetrope added the enhancement New feature or request label May 20, 2024
@zoetrope zoetrope marked this pull request as ready for review May 20, 2024 05:22
Copy link
Contributor

@rkwmt rkwmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that there are still some codes that need to be changed from . to .Name.
Could you please check these files as well?

name: {{ . }}

- cybozu-go:{{ . }}

name: {{ . }}

- {{ . }}

@zoetrope zoetrope requested a review from rkwmt May 22, 2024 09:55
Copy link
Contributor

@rkwmt rkwmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zoetrope zoetrope merged commit 4800448 into main May 23, 2024
10 checks passed
@zoetrope zoetrope deleted the extra-params branch May 23, 2024 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants