Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Native globus rewrite + some more refactoring #125

Merged
merged 131 commits into from
Sep 9, 2024

Conversation

yianzhang14
Copy link
Contributor

@yianzhang14 yianzhang14 commented Jul 14, 2024

  • Rewrote globus functionality in native typescript, removing the need to do use pythonutils/capturing stdouts of forked processes
  • Did not use the globus sdk--just used the basic globus endpoints--all this logic found in the GlobusTransferUtil.ts
  • Made everything to be into a folder to simplify path resolution & to fix the serving of the swagger docs/other documentation outputs (it was broken previously), hence the large amount of path changes
  • Changed linting settings
  • Other miscellaneous changes (package cleanup, optimizing async functions by removing return await clauses, restructuring the initHelloWorldGit function)

Tested on the hello world job with anvil (assuming that keeling is broken)

Copy link
Member

@alexandermichels alexandermichels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested it on test.

@alexandermichels alexandermichels merged commit b065553 into cybergis:v2 Sep 9, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants