Platform names as CloudFormation parameters. #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add UnixPlatformName and WindowsPlatformName as CloudFormartion parameters.
GetParameters API call is restricted to a maximum of 10 array members, preventing boto3 client.get_parameters() from pulling more. This commit fixes the issue by splitting the input array in chunks of 10 and calling the API multiple times. See https://docs.aws.amazon.com/systems-manager/latest/APIReference/API_GetParameters.html
In the Vault Creation Cloudformation template: UnixPlatformName default value is UnixSSHKeys. WindowsSafeName default value
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add the capability to customize Platform Parameters used by the lambda to onboard account.
New parameters are added to the CloudFormation templates, so that the user can specify custom platforms during deployment. Previously hardcoded platforms are now default in the CF template. The README.md has been updated accordingly!
This PR also refactors up code in aws_services::get_params_from_param_store() and circumvent a limitation with the AWS GetParameter API call.