This repository has been archived by the owner on Jan 9, 2021. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deploys project on GKE 1.15.7 #27
Deploys project on GKE 1.15.7 #27
Changes from all commits
67e998d
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel like this is a risky move but maybe it will be fine. I'll leave it as-is.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I did not like adding this, but the first time I ran the 2 test cases in parallel, I saw an
AlreadyExists
error in one test. I didn't expect to see this sort of error whenkubectl apply ...
is being used, but there's apparently a race condition where the 2 instances ofkubectl apply ...
realize that a create is needed, and they both try the create at the same time. It's too bad there's no --ignore-already-created flag or similar to whatever the flag is forkubectl create ...
.