Code refactor, arguments extension #21
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanielNiv
suggested changes
May 8, 2024
There was a problem hiding this comment.
Please rename the file to consts.py
| \____/|_|\___/|_.__/\_| |_/\__,_|_| |_|\__\___|_| | ||
|
|
||
| ------------------------------------------------------------- | ||
| Author: Daniel Niv & Nick Borshchov |
There was a problem hiding this comment.
We will not change the logo for every person who commits, as we have many contributors.
It should be the same as the original.
| subprocess.check_output("az login", shell=True, stderr=subprocess.DEVNULL) | ||
| username = subprocess.check_output("az account show --query user.name", shell=True, | ||
| stderr=subprocess.DEVNULL).decode("utf-8") | ||
| credentials = AzureCliCredential() | ||
| print("[+] Logged in as user {}".format(username.replace('"', '').replace("\n", '')), flush=True) |
There was a problem hiding this comment.
Please change all the strings to f-strings.
There was a problem hiding this comment.
Do we really need the newer packages versions?
|
|
||
|
|
||
| def create_parser(): | ||
| parser = argparse.ArgumentParser(description='The AWS Cloud Post Exploitation framework') |
There was a problem hiding this comment.
This description is not correct.
There was a problem hiding this comment.
Please rename the file to args.py
There was a problem hiding this comment.
Please rename the file to file_ops.py
g3rzi
approved these changes
Jun 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Desired Outcome
Update structure of code, add new arguments
Implemented Changes