WIP on fix for tests in InternalUsersScoreBasedPasswordRulesRestApiIntegrationTest

[cwperks]

Description

WIP on opensearch-project#4845

Check List

• New functionality includes testing
• New functionality has been documented
• New Roles/Permissions have a corresponding security dashboards plugin PR
• API changes companion pull request created
• Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[willyborankin]

@cwperks, thank you for fixing it! Now, each test initializes only once, right?

[cwperks]

@cwperks, thank you for fixing it! Now, each test initializes only once, right?

Yes that's the idea. It also switches to using the @ Before method which does not need to be static and will allow the use of polymorphism for the test. I'm not sure this is the best way just yet which is why it's in a PR on my fork, but I wanted to open this PR to show the code I've already created.

[willyborankin]

@cwperks, thank you for fixing it! Now, each test initializes only once, right?

Yes that's the idea. It also switches to using the @ Before method which does not need to be static and will allow the use of polymorphism for the test. I'm not sure this is the best way just yet which is why it's in a PR on my fork, but I wanted to open this PR to show the code I've already created.

I was planning to do the same. The original idea was to boot up the cluster only once as result all tests passed fast and you can run in you IDEA :-) but unfortunately it was a good idea.

[cwperks]

@cwperks, thank you for fixing it! Now, each test initializes only once, right?

Yes that's the idea. It also switches to using the @ Before method which does not need to be static and will allow the use of polymorphism for the test. I'm not sure this is the best way just yet which is why it's in a PR on my fork, but I wanted to open this PR to show the code I've already created.

I was planning to do the same. The original idea was to boot up the cluster only once as result all tests passed fast and you can run in you IDEA :-) but unfortunately it was a good idea.

If it can be dynamically changed in a single cluster that would be great, but I don't think it's possible. Please feel free to push to this branch. I'm not sure this is the best way to solve these tests.

[willyborankin]

@cwperks, thank you for fixing it! Now, each test initializes only once, right?

Yes that's the idea. It also switches to using the @ Before method which does not need to be static and will allow the use of polymorphism for the test. I'm not sure this is the best way just yet which is why it's in a PR on my fork, but I wanted to open this PR to show the code I've already created.

I was planning to do the same. The original idea was to boot up the cluster only once as result all tests passed fast and you can run in you IDEA :-) but unfortunately it was a good idea.

If it can be dynamically changed in a single cluster that would be great, but I don't think it's possible. Please feel free to push to this branch. I'm not sure this is the best way to solve these tests.

Yes it is. It is my bad :-)