Add FailOnAnonymousAction for SAML auth to get redirect #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Craig Perkins <[email protected]>
cwperks
requested review from
stephen-crawford,
reta and
willyborankin
as code owners
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Companion security-dashboards-plugin PR: cwperks/security-dashboards-plugin#3
Adds FailOnAnonymous action which explicitly will fail an anonymous request so that SAML can get redirect info.
SAML currently calls on the authinfo endpoint and expects it to fail, but it succeeds when anonymous is enabled: https://github.com/opensearch-project/security-dashboards-plugin/blob/main/server/backend/opensearch_security_client.ts#L186
This new endpoint will explicitly fail.