forked from opensearch-project/security
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add exclude_roles
configuration parameter to LDAP authorization backend
#20
Open
cwperks
wants to merge
13
commits into
main
Choose a base branch
from
hide-ldap-roles
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Maciej Mierzwa <[email protected]>
Signed-off-by: Maciej Mierzwa <[email protected]>
Signed-off-by: Maciej Mierzwa <[email protected]>
Signed-off-by: Maciej Mierzwa <[email protected]>
Signed-off-by: Craig Perkins <[email protected]>
Signed-off-by: Craig Perkins <[email protected]>
cwperks
requested review from
stephen-crawford,
reta and
willyborankin
as code owners
February 5, 2024 20:55
cwperks
changed the title
Hide ldap roles
Add Feb 5, 2024
exclude_roles
configuration parameter to LDAP authorization backend
3 tasks
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #20 +/- ##
==========================================
+ Coverage 65.62% 65.85% +0.22%
==========================================
Files 298 298
Lines 21247 21258 +11
Branches 3457 3464 +7
==========================================
+ Hits 13943 13999 +56
+ Misses 5583 5525 -58
- Partials 1721 1734 +13
|
Signed-off-by: Craig Perkins <[email protected]>
Signed-off-by: Craig Perkins <[email protected]>
Signed-off-by: Craig Perkins <[email protected]>
Signed-off-by: Craig Perkins <[email protected]>
Signed-off-by: Craig Perkins <[email protected]>
Signed-off-by: Craig Perkins <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a new config value for LDAP Authorization Backend called
exclude_roles
. This config value lets a cluster administrator configure a list of patterns of roles to exclude from an external LDAP system to limit the backend roles fetched for a user to the most pertinent roles for OpenSearch.