Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create ExecutionContext and show example with RestHandlerProxy #172

Open
wants to merge 87 commits into
base: main
Choose a base branch
from
Open

Create ExecutionContext and show example with RestHandlerProxy #172

wants to merge 87 commits into from

Conversation

cwperks
Copy link
Owner

@cwperks cwperks commented May 30, 2024 •
edited
Loading

Description

This PR creates a new part of the ThreadContext called ExecutionContext that is intended to hold an identifier to the plugin that is currently executing code. Ideally, this class is not exposed to plugins and is populated before the core defers execution to a plugin when handling an API request and is cleared upon returning back to the core.

Related Issues

Related to: opensearch-project/security#4208

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • API changes companion pull request created.
  • Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@cwperks cwperks changed the title Create ExecutionContext and show example with ActionPluginProxy Create ExecutionContext and show example with RestHandlerProxy May 31, 2024
@cwperks cwperks mentioned this pull request Jun 11, 2024
Open
cwperks added 15 commits June 11, 2024 16:08
@cwperks
Add test to verify that ExecutionContext is being populated during Re…
5b989d6 
…stHandling

Signed-off-by: Craig Perkins <[email protected]>
@cwperks
Merge branch 'main' into plugin-aware-thread-context
444fde7
@cwperks
Merge branch 'main' into plugin-aware-thread-context
aaba063
@cwperks
Clear context in a finally block
eec8b96 
Signed-off-by: Craig Perkins <[email protected]>
@cwperks
Create switchContext method in ThreadContext and make pluginExecution…
8a98618 
…Stack a stack

Signed-off-by: Craig Perkins <[email protected]>
@cwperks
Merge branch 'main' into plugin-aware-thread-context
5f7a26f
@cwperks
WIP on plugin aware stash context
6b6e955 
Signed-off-by: Craig Perkins <[email protected]>
@cwperks
Create class called PluginAwareNodeClient that provides a method call…
73835ed 
…ed switchContext

Signed-off-by: Craig Perkins <[email protected]>
@cwperks
Remove ExecutionContext class
4d048b7 
Signed-off-by: Craig Perkins <[email protected]>
@cwperks
Update javadoc
70c0c80 
Signed-off-by: Craig Perkins <[email protected]>
@cwperks
Change createComponents to take in PluginAwareNodeClient
dc5c5a8 
Signed-off-by: Craig Perkins <[email protected]>
@cwperks
Update all instances of createComponents
e26ac6c 
Signed-off-by: Craig Perkins <[email protected]>
@cwperks
Initialize clients
c2e0a64 
Signed-off-by: Craig Perkins <[email protected]>
@cwperks
Merge branch 'main' into plugin-aware-thread-context
1b234b5
@cwperks
Remove casting
1d7df43 
Signed-off-by: Craig Perkins <[email protected]>
@cwperks cwperks force-pushed the plugin-aware-thread-context branch from 55fe24c to 1d7df43 Compare July 16, 2024 13:05
cwperks added 30 commits August 16, 2024 10:59
@cwperks
Add javadoc to NoopPluginSubject
17abb63 
Signed-off-by: Craig Perkins <[email protected]>
@cwperks
Merge branch 'main' into plugin-aware-thread-context
d6be989
@cwperks
Rename to assignSubject
48bd43c 
Signed-off-by: Craig Perkins <[email protected]>
@cwperks
Add experimental label
be9a89a 
Signed-off-by: Craig Perkins <[email protected]>
@cwperks
Add getPluginSubject(plugin) to IdentityPlugin
ca1f297 
Signed-off-by: Craig Perkins <[email protected]>
@cwperks
Make runAs generic
84c0cc3 
Signed-off-by: Craig Perkins <[email protected]>
@cwperks
package-private constructor
c200272 
Signed-off-by: Craig Perkins <[email protected]>
@cwperks
Move IdentityAwarePlugin initialization
be9b3cc 
Signed-off-by: Craig Perkins <[email protected]>
@cwperks
Create separate PluginSubject interface
9c07676 
Signed-off-by: Craig Perkins <[email protected]>
@cwperks
Remove authenticate method
901d53d 
Signed-off-by: Craig Perkins <[email protected]>
@cwperks
Remove import
55834df 
Signed-off-by: Craig Perkins <[email protected]>
@cwperks
Separate UserSubject and PluginSubject
7374479 
Signed-off-by: Craig Perkins <[email protected]>
@cwperks
Terminate TestThreadPool
efac919 
Signed-off-by: Craig Perkins <[email protected]>
@cwperks
mock ThreadPool in RestSendToExtensionActionTests
1536380 
Signed-off-by: Craig Perkins <[email protected]>
@cwperks
Fix Thread leak
e6eb37e 
Signed-off-by: Craig Perkins <[email protected]>
@cwperks
Add to CHANGELOG
2c9ba56 
Signed-off-by: Craig Perkins <[email protected]>
@cwperks
Rename to getCurrentSubject
9c5b2c4 
Signed-off-by: Craig Perkins <[email protected]>
@cwperks
Add type check
4b8c7bd 
Signed-off-by: Craig Perkins <[email protected]>
@cwperks
Merge branch 'main' into plugin-aware-thread-context
5ab2f50 
Signed-off-by: Craig Perkins <[email protected]>
@cwperks
Rename to pluginSubject
1a468e7 
Signed-off-by: Craig Perkins <[email protected]>
@cwperks
Merge branch 'main' into plugin-aware-thread-context
df6b5ce
@cwperks
Merge branch 'main' into plugin-aware-thread-context
57f233b
@cwperks
Merge branch 'main' into plugin-aware-thread-context
311b019
@cwperks
Merge branch 'main' into plugin-aware-thread-context
7a4c80c 
Signed-off-by: Craig Perkins <[email protected]>
@cwperks
Add runAs to ActionRequest and surround doExecute in AbstractClient
c74c677 
Signed-off-by: Craig Perkins <[email protected]>
@cwperks
Return this
06259f7 
Signed-off-by: Craig Perkins <[email protected]>
@cwperks
Switch back to void
fc5459d 
Signed-off-by: Craig Perkins <[email protected]>
@cwperks
Revert change to ActionRequest
653beb4 
Signed-off-by: Craig Perkins <[email protected]>
@cwperks
Merge branch 'main' into plugin-aware-thread-context
a872e7c
@cwperks
Merge branch 'main' into plugin-aware-thread-context
681ea8f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@cwperks