Ensure only single instance for each classpath extension

Signed-off-by: Craig Perkins <[email protected]>
cwperks · Dec 14, 2024 · 7b4d7d7 · 7b4d7d7
1 parent 44a4042
commit 7b4d7d7
Showing 1 changed file with 10 additions and 2 deletions.
diff --git a/server/src/main/java/org/opensearch/plugins/PluginsService.java b/server/src/main/java/org/opensearch/plugins/PluginsService.java
@@ -159,8 +159,8 @@ public PluginsService(
             pluginsLoaded.add(new Tuple<>(pluginInfo, plugin));
             pluginsList.add(pluginInfo);
             pluginsNames.add(pluginInfo.getName());
-            loadExtensions(pluginsLoaded);
         }
+        loadExtensions(pluginsLoaded);
 
         Set<Bundle> seenBundles = new LinkedHashSet<>();
         List<PluginInfo> modulesList = new ArrayList<>();
@@ -571,9 +571,17 @@ private static void loadExtensionsForPlugin(ExtensiblePlugin extensiblePlugin, L
         ExtensiblePlugin.ExtensionLoader extensionLoader = new ExtensiblePlugin.ExtensionLoader() {
             @Override
             public <T> List<T> loadExtensions(Class<T> extensionPointType) {
+                Set<Class<?>> seenClasses = new LinkedHashSet<>();
                 List<T> result = new ArrayList<>();
+
                 for (Plugin extendingPlugin : extendingPlugins) {
-                    result.addAll(createExtensions(extensionPointType, extendingPlugin));
+                    List<? extends T> extensions = createExtensions(extensionPointType, extendingPlugin);
+                    for (T extension : extensions) {
+                        // Only add if we haven't seen this class before, needed for classpath extensions for testing
+                        if (seenClasses.add(extension.getClass())) {
+                            result.add(extension);
+                        }
+                    }
                 }
                 return Collections.unmodifiableList(result);
             }