Skip to content

Commit

Permalink
WIP on fixing docker-compose issues
Browse files Browse the repository at this point in the history
Signed-off-by: Craig Perkins <[email protected]>
  • Loading branch information
cwperks committed Sep 23, 2024
1 parent a2203ec commit 4954727
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 6 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -125,10 +125,7 @@ public DockerAvailability getDockerAvailability() {
lastResult = runCommand(dockerPath, "images");

// If docker all checks out, see if docker-compose is available and working
Optional<String> composePath = getDockerComposePath();
if (lastResult.isSuccess() && composePath.isPresent()) {
isComposeAvailable = runCommand(composePath.get(), "version").isSuccess();
}
isComposeAvailable = runCommand(dockerPath, "compose", "version").isSuccess();
}
}
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -171,7 +171,7 @@ public void execute(Task task) {
.findFirst();

composeExtension.getExecutable().set(dockerCompose.isPresent() ? dockerCompose.get() : "/usr/bin/docker");
composeExtension.getUseDockerComposeV2().set(false);
composeExtension.getUseDockerComposeV2().set(true);

tasks.named("composeUp").configure(t -> {
// Avoid running docker-compose tasks in parallel in CI due to some issues on certain Linux distributions
Expand Down
5 changes: 4 additions & 1 deletion test/fixtures/gcs-fixture/docker-compose.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
version: '3'
services:
gcs-fixture:
image: gcs_fixture_image
build:
context: .
args:
Expand All @@ -13,6 +13,7 @@ services:
ports:
- "80"
gcs-fixture-third-party:
image: gcs_fixture_image
build:
context: .
args:
Expand All @@ -25,6 +26,7 @@ services:
ports:
- "80"
gcs-fixture-other:
image: gcs_fixture_image
build:
context: .
args:
Expand All @@ -37,6 +39,7 @@ services:
ports:
- "80"
gcs-fixture-repositories-metering:
image: gcs_fixture_image
build:
context: .
args:
Expand Down

0 comments on commit 4954727

Please sign in to comment.