Add SIMULATED_REQUEST

Signed-off-by: Craig Perkins <[email protected]>
cwperks · Dec 15, 2023 · 10f411a · 10f411a
1 parent 48e61d5
commit 10f411a
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 11 deletions.
diff --git a/...les/lang-mustache/src/main/java/org/opensearch/script/mustache/SearchTemplateRequest.java b/...les/lang-mustache/src/main/java/org/opensearch/script/mustache/SearchTemplateRequest.java
@@ -60,6 +60,7 @@
  */
 public class SearchTemplateRequest extends ActionRequest implements IndicesRequest.Replaceable, CompositeIndicesRequest, ToXContentObject {
 
+    private static SearchRequest SIMULATED_REQUEST = new SearchRequest(new String[0]);
     private SearchRequest request;
     private boolean simulate = false;
     private boolean explain = false;
@@ -119,6 +120,9 @@ public boolean isSimulate() {
     }
 
     public void setSimulate(boolean simulate) {
+        if (simulate) {
+            this.request = SIMULATED_REQUEST;
+        }
         this.simulate = simulate;
     }
 
@@ -259,25 +263,16 @@ public void writeTo(StreamOutput out) throws IOException {
 
     @Override
     public String[] indices() {
-        if (simulate) {
-            return new String[0];
-        }
         return request.indices();
     }
 
     @Override
     public IndicesOptions indicesOptions() {
-        if (simulate) {
-            return SearchRequest.DEFAULT_INDICES_OPTIONS;
-        }
         return request.indicesOptions();
     }
 
     @Override
     public IndicesRequest indices(String... indices) {
-        if (simulate) {
-            return request;
-        }
         return request.indices(indices);
     }
 }
diff --git a/...ang-mustache/src/test/java/org/opensearch/script/mustache/SearchTemplateRequestTests.java b/...ang-mustache/src/test/java/org/opensearch/script/mustache/SearchTemplateRequestTests.java
@@ -114,11 +114,10 @@ public static SearchTemplateRequest createRandomRequest() {
 
     public void testSimulatedSearchTemplateRequest() {
         SearchTemplateRequest request = createRandomRequest();
-        request.setRequest(null);
         request.setSimulate(true);
 
         assertEquals(0, request.indices().length);
         assertEquals(SearchRequest.DEFAULT_INDICES_OPTIONS, request.indicesOptions());
-        assertNull(request.indices("index1", "index2"));
+        assertEquals(2, request.indices("index1", "index2").indices().length);
     }
 }