[Refactor] Use iterative approach to evaluate Regex.simpleMatch (open…

…search-project#11060) * Remove adjacent duplicates to optimize regex before processing Signed-off-by: Craig Perkins <[email protected]> * Add tests Signed-off-by: Craig Perkins <[email protected]> * Rename to removeAdjacentDuplicates Signed-off-by: Craig Perkins <[email protected]> * Add additional test case Signed-off-by: Craig Perkins <[email protected]> * Add CHANGELOG entry Signed-off-by: Craig Perkins <[email protected]> * Throw IllegalArgumentException if input is invalid Signed-off-by: Craig Perkins <[email protected]> * Add a space Signed-off-by: Craig Perkins <[email protected]> * Change error message Signed-off-by: Craig Perkins <[email protected]> * Use iterative solution with 2 pointers Signed-off-by: Craig Perkins <[email protected]> * Remove unused method Signed-off-by: Craig Perkins <[email protected]> * add tests and changelog Signed-off-by: Stephen Crawford <[email protected]> * remove bad push Signed-off-by: Stephen Crawford <[email protected]> * Update CHANGELOG.md Signed-off-by: Stephen Crawford <[email protected]> * Update CHANGELOG.md Signed-off-by: Stephen Crawford <[email protected]> * spotless Signed-off-by: Stephen Crawford <[email protected]> * Update comment Signed-off-by: Craig Perkins <[email protected]> * re-run CI Signed-off-by: Craig Perkins <[email protected]> --------- Signed-off-by: Craig Perkins <[email protected]> Signed-off-by: Craig Perkins <[email protected]> Signed-off-by: Stephen Crawford <[email protected]> Signed-off-by: Stephen Crawford <[email protected]> Co-authored-by: Stephen Crawford <[email protected]> Co-authored-by: Stephen Crawford <[email protected]> (cherry picked from commit 61a598b)
cwperks · Dec 1, 2023 · 01df38a · 01df38a
1 parent 0a7ca6c
commit 01df38a
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -15,4 +15,3 @@ Inspired from [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
 ### Fixed
 ### Security
 
-[Unreleased]: https://github.com/opensearch-project/OpenSearch/compare/1.3.12...HEAD
diff --git a/server/src/test/java/org/opensearch/common/regex/RegexTests.java b/server/src/test/java/org/opensearch/common/regex/RegexTests.java
@@ -96,6 +96,7 @@ public void testDoubleWildcardMatch() {
         assertFalse(Regex.simpleMatch("fff**ddd", "fffabcdd"));
         assertTrue(Regex.simpleMatch("fff*******ddd", "fffabcddd"));
         assertTrue(Regex.simpleMatch("fff*******ddd", "FffAbcdDd", true));
+        assertFalse(Regex.simpleMatch("fff*******ddd", "FffAbcdDd", false));
         assertFalse(Regex.simpleMatch("fff******ddd", "fffabcdd"));
         assertFalse(Regex.simpleMatch("fff*******ddd", "FffAbcdDd", false));
         assertTrue(Regex.simpleMatch("abCDefGH******ddd", "abCDefGHddd", false));
Original file line number	Diff line number	Diff line change
Expand Up		@@ -15,4 +15,3 @@ Inspired from [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
		### Fixed
		### Security

		[Unreleased]: https://github.com/opensearch-project/OpenSearch/compare/1.3.12...HEAD