Add certificate request #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openface
reviewed
Apr 5, 2019
cert.go
Outdated
| @@ -273,6 +322,20 @@ func (c *Certificate) Sign(privKey PrivateKey, digest EVP_MD) error { | |||
| return c.insecureSign(privKey, digest) | |||
| } | |||
|
|
|||
| // Sign a certificate using a private key and a digest name. | |||
There was a problem hiding this comment.
Shouldn't this comment read "Sign a certificate request using a private key and a digest name."
There was a problem hiding this comment.
That it should. Good catch, a lot of this is copied and pasted.
Add MarshalDER to certificateRequest Add LoadCertificateRequestFromDER Add Free given intermittent failures with Finalizer
cwjenkins
force-pushed
the
add_certificate_request
branch
from
362e09e to
fbaf2fa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add MarshalDER to certificateRequest
Add LoadCertificateRequestFromDER